Skip to content

Add Time to live labels in A* slurm Integration tests#5283

Merged
saara-tyagi27 merged 2 commits into
GoogleCloudPlatform:developfrom
saara-tyagi27:add-labels
Feb 26, 2026
Merged

Add Time to live labels in A* slurm Integration tests#5283
saara-tyagi27 merged 2 commits into
GoogleCloudPlatform:developfrom
saara-tyagi27:add-labels

Conversation

@saara-tyagi27

@saara-tyagi27 saara-tyagi27 commented Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Add Time-to-live label which is current_time+4 hrs in A* Slurm integration tests.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

gemini-code-assist Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @saara-tyagi27, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the daily test infrastructure by implementing automatic Time-To-Live (TTL) labeling for resources provisioned during A* Slurm integration tests. By programmatically adding a TTL label set for 4 hours into the test blueprints, the change ensures that temporary test environments are marked for eventual cleanup, thereby improving resource hygiene and reducing potential cloud costs associated with forgotten or lingering test instances.

Highlights

  • Time-To-Live (TTL) Labeling: Introduced a mechanism to calculate and apply a 'time-to-live' label to resources created by A* Slurm integration tests. This label is set to the current UTC time plus 4 hours.
  • Blueprint Modification: Modified several ml-a*-slurm.yaml daily test build configurations to dynamically inject the calculated TTL label into their respective blueprint YAML files using sed.
  • Resource Management: The addition of TTL labels aims to facilitate automatic cleanup of test resources, preventing orphaned instances and optimizing cloud resource usage.
Changelog
  • tools/cloud-build/daily-tests/builds/ml-a3-highgpu-onspot-slurm.yaml
    • Defined the BLUEPRINT variable pointing to the A3 HighGPU Slurm blueprint.
    • Added shell commands to calculate a TTL_LABEL (current UTC time + 4 hours) and inject it into the blueprint's vars section.
  • tools/cloud-build/daily-tests/builds/ml-a3-highgpu-slurm.yaml
    • Defined the BLUEPRINT variable pointing to the A3 HighGPU Slurm blueprint.
    • Added shell commands to calculate a TTL_LABEL (current UTC time + 4 hours) and inject it into the blueprint's vars section.
  • tools/cloud-build/daily-tests/builds/ml-a3-megagpu-onspot-slurm-ubuntu.yaml
    • Added shell commands to calculate a TTL_LABEL (current UTC time + 4 hours) and inject it into the blueprint's vars section.
  • tools/cloud-build/daily-tests/builds/ml-a3-megagpu-slurm-ubuntu.yaml
    • Added shell commands to calculate a TTL_LABEL (current UTC time + 4 hours) and inject it into the blueprint's vars section.
  • tools/cloud-build/daily-tests/builds/ml-a4-highgpu-onspot-slurm.yaml
    • Added shell commands to calculate a TTL_LABEL (current UTC time + 4 hours) and inject it into the blueprint's vars section.
Activity
  • No human activity (comments, reviews) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 25, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a time-to-live label to various SLURM integration tests, which is a good practice for ensuring cleanup of test resources. While the intent is good, the implementation introduces significant code duplication across five separate Cloud Build YAML files. This repeated logic could be centralized into a shared script for better maintainability. Additionally, the sed command used to inject the label is brittle and could cause build failures if the target blueprint files are modified in the future. My review includes suggestions to address these points.

Comment thread tools/cloud-build/daily-tests/builds/ml-a3-highgpu-onspot-slurm.yaml Outdated
@saara-tyagi27 saara-tyagi27 added the release-chore To not include into release notes label Feb 25, 2026
@saara-tyagi27 saara-tyagi27 marked this pull request as ready for review February 25, 2026 14:57
@saara-tyagi27 saara-tyagi27 requested review from a team and samskillman as code owners February 25, 2026 14:57
@saara-tyagi27 saara-tyagi27 requested a review from LAVEEN February 25, 2026 14:58
@saara-tyagi27 saara-tyagi27 merged commit ded4987 into GoogleCloudPlatform:develop Feb 26, 2026
20 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LAVEEN LAVEEN LAVEEN approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saara-tyagi27 @LAVEEN