Skip to content

Revert "Update provider_meta module_name for login module"#5314

Merged
sudheer-quad merged 1 commit into
developfrom
revert-5276-fix/provider-meta-module-name
Mar 6, 2026
Merged

Revert "Update provider_meta module_name for login module"#5314
sudheer-quad merged 1 commit into
developfrom
revert-5276-fix/provider-meta-module-name

Conversation

@sudheer-quad

Copy link
Copy Markdown
Contributor

Reverts #5276

@sudheer-quad sudheer-quad requested review from a team and samskillman as code owners March 5, 2026 12:32
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an erroneous update by reverting a previous commit that had incorrectly modified the module_name within the provider_meta block for the SLURM GCP login module's versions.tf file. The change restores the correct module identification, ensuring proper tracking and functionality.

Highlights

  • Revert Previous Change: This pull request reverts a prior commit (Update provider_meta module_name for login module #5276) that incorrectly updated the provider_meta module_name for the SLURM GCP login module.
  • versions.tf Update: The module_name in community/modules/internal/slurm-gcp/login/versions.tf was reverted from blueprints/terraform/hpc-toolkit:schedmd-slurm-gcp-v6-login/v1.83.0 back to blueprints/terraform/hpc-toolkit:schedmd-slurm-gcp-v6-controller/v1.82.0.
Changelog
  • community/modules/internal/slurm-gcp/login/versions.tf
    • Reverted the module_name in the google provider metadata to its previous correct value.
Activity
  • No human activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the external PR from external contributor label Mar 5, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

After reviewing the provided comments against the established rules, no specific feedback comments were found to be applicable or compliant with the repository's guidelines. The original comment regarding the provider_meta module_name and version was found to contradict the rule that module versions in provider_meta should align with the current release process, leading to its removal.

@sudheer-quad sudheer-quad added the release-chore To not include into release notes label Mar 5, 2026
@sudheer-quad sudheer-quad merged commit a506162 into develop Mar 6, 2026
12 of 81 checks passed
@aslam-quad aslam-quad deleted the revert-5276-fix/provider-meta-module-name branch March 9, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants