Skip to content

Update provider_meta module_name for login module#5276

Merged
sudheer-quad merged 2 commits into
GoogleCloudPlatform:developfrom
sudheer-quad:fix/provider-meta-module-name
Feb 24, 2026
Merged

Update provider_meta module_name for login module#5276
sudheer-quad merged 2 commits into
GoogleCloudPlatform:developfrom
sudheer-quad:fix/provider-meta-module-name

Conversation

@sudheer-quad

@sudheer-quad sudheer-quad commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

This PR updates the module_name in the provider_meta block to schedmd-slurm-gcp-v6-login. Previously, this field was incorrectly set to controller, resulting in inaccurate telemetry.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@sudheer-quad sudheer-quad requested review from a team and samskillman as code owners February 24, 2026 10:07
@github-actions github-actions Bot added the external PR from external contributor label Feb 24, 2026
@gemini-code-assist

gemini-code-assist Bot commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @sudheer-quad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inaccuracy in telemetry reporting for the slurm-gcp login module. By correcting the module_name within the Terraform provider_meta configuration, it ensures that usage data is correctly attributed to the login component rather than the controller, thereby improving the fidelity of collected metrics.

Highlights

  • Telemetry Correction: The module_name in the provider_meta block for the login module was updated from schedmd-slurm-gcp-v6-controller to schedmd-slurm-gcp-v6-login. This correction ensures accurate telemetry reporting for the login module.
Changelog
  • community/modules/internal/slurm-gcp/login/versions.tf
    • Updated the module_name in the provider_meta block to reflect the correct login module identifier.
Activity
  • No activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 24, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR correctly addresses an issue with inaccurate telemetry by updating the module_name in the provider_meta block. I've added a suggestion to align the module version with its corresponding public module for consistency.

Comment thread community/modules/internal/slurm-gcp/login/versions.tf
@sudheer-quad sudheer-quad added the release-chore To not include into release notes label Feb 24, 2026
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes Feb 24, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding reference: #5275 (comment)

@sudheer-quad sudheer-quad merged commit 98c4b30 into GoogleCloudPlatform:develop Feb 24, 2026
12 of 85 checks passed
@sudheer-quad sudheer-quad mentioned this pull request Mar 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@agrawalkhushi18 agrawalkhushi18 agrawalkhushi18 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sudheer-quad @SwarnaBharathiMantena @agrawalkhushi18