Skip to content

Update gke-versioning in gpu_direct.tf#5284

Merged
agrawalkhushi18 merged 3 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:gke-version
Feb 27, 2026
Merged

Update gke-versioning in gpu_direct.tf#5284
agrawalkhushi18 merged 3 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:gke-version

Conversation

@agrawalkhushi18

@agrawalkhushi18 agrawalkhushi18 commented Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR updates the gke-version specified for the hardware-specific features of GPUDirect (TCPX/TCPXO) and README.md of examples.
The security-bulletin (https://docs.cloud.google.com/kubernetes-engine/security-bulletins) discovered some vulnerabilities with the versions.

In gpu_direct.tf:
For a3-high: Updated 1.27, 1.28 & 1.29 and removed the patch version for 1.30 since exclusive pinning of version for 1.30 to 1.33 is not required.
For a3-mega: Updated 1.28,1.29,1.30, 1.31 and 1.32 as per security bulletin mentioned above.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@agrawalkhushi18 agrawalkhushi18 added the release-version-updates Added to release notes under the "Version Updates" heading. label Feb 25, 2026
@gemini-code-assist

gemini-code-assist Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @agrawalkhushi18, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the specified GKE versions within the gpu_direct.tf module, primarily affecting GPUDirect configurations for a3-high and a3-megagpu-8g node pools. The changes are a direct response to a recent security bulletin, ensuring that the deployed GKE clusters utilize patched versions to mitigate identified vulnerabilities.

Highlights

  • GKE Version Updates: Updated GKE versions for GPUDirect (TCPX/TCPXO) hardware-specific features to address vulnerabilities identified in security bulletin GCP-2026-007.
  • a3-high Configuration: Removed the explicit patch version for GKE 1.30, as exclusive pinning is no longer required for this configuration.
  • a3-megagpu-8g Configuration: Updated GKE versions for 1.30, 1.31, and 1.32 to newer, more secure patch releases.
Changelog
  • modules/compute/gke-node-pool/gpu_direct.tf
    • Removed the explicit 1.30 GKE version entry for the a3-high configuration.
    • Updated the 1.30, 1.31, and 1.32 GKE versions for the a3-megagpu-8g configuration to newer patch releases.
Activity
  • No human activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 25, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GKE version pinning for a3-highgpu-8g and a3-megagpu-8g machine types to align with the security bulletin GCP-2026-007. The changes involve removing a version pin for 1.30 on a3-highgpu-8g and updating the minimum required versions for 1.30, 1.31, and 1.32 on a3-megagpu-8g. The changes appear correct based on the description. The suggestion to improve code maintainability by documenting the reason for the version changes directly in the code has been kept as it does not contradict any provided rules.

Comment thread modules/compute/gke-node-pool/gpu_direct.tf
@agrawalkhushi18 agrawalkhushi18 marked this pull request as ready for review February 26, 2026 06:13
@agrawalkhushi18 agrawalkhushi18 requested review from a team and samskillman as code owners February 26, 2026 06:13
shubpal07
shubpal07 approved these changes Feb 27, 2026
View reviewed changes

@shubpal07 shubpal07 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agrawalkhushi18 agrawalkhushi18 merged commit bf18385 into GoogleCloudPlatform:develop Feb 27, 2026
20 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gokamesh gokamesh gokamesh approved these changes

@shubpal07 shubpal07 shubpal07 approved these changes

@SwarnaBharathiMantena SwarnaBharathiMantena Awaiting requested review from SwarnaBharathiMantena

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version-updates Added to release notes under the "Version Updates" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agrawalkhushi18 @gokamesh @shubpal07