Add ttl labels to gke integration tests#5292
Conversation
Summary of ChangesHello @saara-tyagi27, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances resource management for GKE integration tests by systematically applying Time-To-Live (TTL) labels to the blueprints used in Cloud Build daily test runs. This ensures that test-provisioned resources are automatically cleaned up after a set duration, preventing orphaned resources and optimizing cloud costs. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a time-to-live label to various integration test blueprints to facilitate automatic resource cleanup. The changes are mostly correct, but I've identified a critical bug due to a variable name mismatch in one of the test files and a likely incorrect blueprint path in another. Please address these points to ensure the tests run correctly.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a time-to-live label to various integration test blueprints to automatically clean up resources after a set duration. This is achieved by adding a call to the add_ttl_label.sh script within the Cloud Build configurations. The changes are applied consistently across a large number of test files. My review identifies a minor inconsistency where shell variables are not always quoted. I've added comments with suggestions to quote these variables for improved script robustness and consistency with the other changes in this PR. All comments have been retained as they align with existing practices and do not contradict any provided rules.
42776d5 to
6d5df97
Compare
6d5df97 to
459d4a1
Compare
|
ml-a4-high-custom blueprint is failing due to deep learning image not found. |
7951f79
into
GoogleCloudPlatform:develop
Summary
Add time-to-live labels to gke focused integration tests
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.