Skip to content

Merge v1.83.0 to develop#5318

Merged
sudheer-quad merged 10 commits into
GoogleCloudPlatform:developfrom
cboneti:sync-main-to-develop
Mar 6, 2026
Merged

Merge v1.83.0 to develop#5318
sudheer-quad merged 10 commits into
GoogleCloudPlatform:developfrom
cboneti:sync-main-to-develop

Conversation

@cboneti

@cboneti cboneti commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR merges main in to develop, bringing the latest hotfixes and version updates.

sudheer-quad and others added 10 commits February 24, 2026 08:54
@sudheer-quad
Increase version to 1.83.0
0708266
@sudheer-quad
Update Toolkit release to v1.83.0 (GoogleCloudPlatform#5275)
e790113
@SwarnaBharathiMantena
Hotfix: update G4 NVIDIA drivers for kernel 6.17 compatibility (Googl…
c8fa496 
…eCloudPlatform#5289)
@SwarnaBharathiMantena
Hotfix: Update the region and zone(s) to overcome Lustre instance cre…
80f0b3b 
…ation issue (GoogleCloudPlatform#5290)
@kadupoornima
hardcode zone
cab05f9
@kadupoornima
Hardcode zone in a2high PR test to fix test failures (GoogleCloudPlat…
44196de 
…form#5305)
@vikramvs-gg
Modifying prefix_length for PSA to accomodate sufficient IPs for peer…
8f655b4 
…ing (GoogleCloudPlatform#5306)
@agrawalkhushi18
fix: Update a3m and a3u script to resolve slurm nccl test failure (Go…
8eb5de0 
…ogleCloudPlatform#5308)
@sudheer-quad
Release candidate : v1.83.0 (GoogleCloudPlatform#5277)
09301db
@cboneti
Merge remote-tracking branch 'origin/main' into develop
0de7784
@cboneti cboneti requested review from a team and samskillman as code owners March 6, 2026 08:22
@cboneti cboneti changed the base branch from main to develop March 6, 2026 08:24
@gemini-code-assist

gemini-code-assist Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates recent changes from the main branch into develop, focusing on improving resource validation, updating GKE version compatibility, and enhancing automated resource lifecycle management. A new disk type validator has been added, GKE version requirements in examples and modules have been updated, and a new utility script for applying time-to-live labels has been introduced and integrated into daily tests and the cleanup process for Managed Lustre instances. These changes collectively aim to ensure blueprints remain current, valid, and efficiently managed.

Highlights

  • New Disk Type Validation: Introduced a new validator, test_disk_type_in_zone, to verify the availability of specified disk types within a given Google Cloud zone. This mirrors the existing machine type validation and is automatically added to default blueprint validations.
  • GKE Version Updates: Updated recommended and minimum GKE versions across various examples and Terraform modules, including A4X-Max, TPU Flex Start (7x and v6e), G4, H4D, and Cloud TPU 7x, ensuring compatibility with the latest GKE releases.
  • Automated TTL Labeling: Added a new shell script (tools/add_ttl_label.sh) that automatically inserts or updates a time-to-live label within the vars: block of blueprint YAML files. This script has been integrated into several Cloud Build daily tests to facilitate automated resource cleanup.
  • Managed Lustre Cleanup Integration: Enhanced the tools/cleanup.sh script to include Managed Lustre instances in its resource protection and deletion logic. The script now leverages the time-to-live label to determine which Lustre instances should be excluded from cleanup.
  • Go Module Dependency Updates: Updated the github.com/go-git/go-git/v5 and github.com/cloudflare/circl Go modules to their latest patch versions, along with corresponding go.sum checksums.
Changelog
  • docs/blueprint-validation.md
    • Documented the new test_disk_type_in_zone validator.
  • examples/gke-a4x-max-bm/README.md
    • Updated the recommended GKE version for A4X-Max support.
  • examples/gke-consumption-options/dws-flex-start/gke-tpu-7x/README.md
    • Updated GKE version references in the example output for TPU Flex Start (7x).
  • examples/gke-consumption-options/dws-flex-start/gke-tpu-v6e/README.md
    • Updated GKE version references in the example output for TPU Flex Start (v6e).
  • examples/gke-g4/README.md
    • Updated the minimum required GKE version for G4 support.
  • examples/gke-h4d/README.md
    • Updated the minimum required GKE version for H4D support.
  • examples/gke-tpu-7x/README.md
    • Updated the minimum required GKE version for Cloud TPU 7x.
  • go.mod
    • Updated github.com/go-git/go-git/v5 from v5.16.4 to v5.16.5.
    • Updated github.com/cloudflare/circl from v1.6.1 to v1.6.3.
  • go.sum
    • Updated checksums to reflect changes in go.mod.
  • modules/compute/gke-node-pool/gpu_direct.tf
    • Updated acceptable GKE versions for various GPU types (A3, A3 MegaGPU).
  • pkg/validators/cloud.go
    • Refactored testMachineTypeInZoneAvailability into a generic testResourceInZoneAvailability function.
    • Added testDiskTypeInZoneAvailability using the new generic resource validation function.
    • Removed the old testMachineTypeInZoneAvailability implementation.
  • pkg/validators/cloud_discovery.go
    • Introduced handleResourceInZoneValidationError for standardized error processing.
    • Modified validateMachineTypeInZone to use the new error handling function.
    • Added validateDiskTypeInZone to verify disk type availability in a zone.
  • pkg/validators/validators.go
    • Defined testDiskTypeInZone constant.
    • Registered testDiskTypeInZoneAvailability in the validator implementations map.
    • Added testDiskTypeInZone to the list of default validators.
  • pkg/validators/validators_test.go
    • Added test cases for TestValidateDiskTypeInZone covering success, soft warning, and hard failure scenarios.
    • Updated TestDefaultValidators to include diskTypeInZone in expected default validators.
  • tools/add_ttl_label.sh
    • Added a new shell script to programmatically add or update a time-to-live label in blueprint YAML files.
  • tools/cleanup.sh
    • Extended resource protection logic to include Managed Lustre instances.
    • Implemented deletion logic for Managed Lustre instances based on time-to-live labels.
  • tools/cloud-build/daily-tests/builds/ml-a3-highgpu-onspot-slurm.yaml
    • Integrated tools/add_ttl_label.sh to apply TTL labels to blueprints.
  • tools/cloud-build/daily-tests/builds/ml-a3-highgpu-slurm.yaml
    • Integrated tools/add_ttl_label.sh to apply TTL labels to blueprints.
  • tools/cloud-build/daily-tests/builds/ml-a3-megagpu-onspot-slurm-ubuntu.yaml
    • Integrated tools/add_ttl_label.sh to apply TTL labels to blueprints.
  • tools/cloud-build/daily-tests/builds/ml-a3-megagpu-slurm-ubuntu.yaml
    • Integrated tools/add_ttl_label.sh to apply TTL labels to blueprints.
  • tools/cloud-build/daily-tests/builds/ml-a3-ultragpu-custom-blueprint-test.yaml
    • Integrated tools/add_ttl_label.sh to apply TTL labels to blueprints.
  • tools/cloud-build/daily-tests/builds/ml-a3-ultragpu-onspot-jbvms.yaml
    • Integrated tools/add_ttl_label.sh to apply TTL labels to blueprints.
  • tools/cloud-build/daily-tests/builds/ml-a3-ultragpu-onspot-slurm.yaml
    • Modified Cloud Build configuration to directly apply a time-to-live label to the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a4-highgpu-onspot-slurm.yaml
    • Integrated tools/add_ttl_label.sh to apply TTL labels to blueprints.
  • tools/publish_release.sh
    • Added a new script to publish release manifests to Google Cloud Storage.
  • tools/validate_configs/validate_configs.sh
    • Updated the list of validators to skip during config validation to include test_disk_type_in_zone.
Activity
  • The pull request was opened by cboneti.
  • No specific human activity (comments, reviews, or progress updates) has been recorded in the provided context since the pull request was created.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 6, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily updates module versions from v1.82.0 to v1.83.0, adjusts example configurations (e.g., prefix_length for private service access, NVIDIA driver packages in Slurm), fixes test configurations, and improves shell scripts for container environment setup. A security vulnerability was identified in the shell scripts for importing PyTorch containers: temporary directories are created insecurely in /tmp when XDG_RUNTIME_DIR is not set, which could lead to unauthorized access or manipulation of temporary files. To mitigate this, I've suggested using mktemp for secure temporary directory creation in the affected scripts, aligning with repository guidelines for secure temporary file handling in shell scripts. Other changes, such as the update to NVIDIA driver versions and the use of force-overwrite in Ansible tasks, were reviewed and found to be acceptable.

Comment thread examples/machine-learning/a3-megagpu-8g/nccl-tests/import_pytorch_container.sh
Comment thread examples/machine-learning/a3-ultragpu-8g/nccl-tests/import_pytorch_container.sh
@cboneti cboneti added the release-chore To not include into release notes label Mar 6, 2026
@sudheer-quad sudheer-quad changed the title Sync main to develop Sync v1.83.0 main to develop Mar 6, 2026
@sudheer-quad sudheer-quad changed the title Sync v1.83.0 main to develop Merged v1.83.0 main to develop Mar 6, 2026
@sudheer-quad sudheer-quad changed the title Merged v1.83.0 main to develop Merge v1.83.0 main to develop Mar 6, 2026
@sudheer-quad sudheer-quad changed the title Merge v1.83.0 main to develop Merge v1.83.0 to develop Mar 6, 2026
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes Mar 6, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudheer-quad sudheer-quad merged commit d992d20 into GoogleCloudPlatform:develop Mar 6, 2026
30 of 97 checks passed
@cboneti cboneti deleted the sync-main-to-develop branch March 6, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@samskillman samskillman Awaiting requested review from samskillman

@agrawalkhushi18 agrawalkhushi18 Awaiting requested review from agrawalkhushi18

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cboneti @SwarnaBharathiMantena @sudheer-quad @kadupoornima @vikramvs-gg @agrawalkhushi18