Modifying prefix_length for PSA to accomodate sufficient IPs for peering#5306
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an IP exhaustion issue within the GKE-managed Lustre service by expanding the allocated IP range for Private Service Access (PSA). The Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly increases the prefix_length for Private Service Access from 24 to 22 to provide a larger IP range for gke-managed-lustre, which is necessary for the service to function correctly. The change is consistently applied across the main gke-managed-lustre blueprint, several other examples where Lustre is an option, and the module's documentation. My review includes suggestions to add explanatory comments to these changes, which align with the repository's style guide and do not contradict any established rules. This will improve the long-term maintainability and clarity of the blueprints by explaining why this specific value is used.
8f655b4
into
GoogleCloudPlatform:release-candidate
Fix: Increase PSA IP range for gke-managed-lustre
The gke-managed-lustre blueprint allocates a /24 range for PSA (prefix_length: 24). The Managed Lustre service requires a certain number of IPs within the producer network that is peered with VPC. A /24 looks to be insufficient for the internal needs of the services.
This change increases the allocated range size by modifying the
prefix_lengthin theprivate-service-accessmodule from24to22. This increases the number of IP addresses reserved for the service producer, making it more resilient to IP exhaustion within the tenant project.Testing: The integration test associated with gke-managed-lustre blueprint is now successful with the change which was failing due to PSA IPs exhausted for service earlier.