Related Posts: do not add markup to attachment pages by default.#12124
Merged
Related Posts: do not add markup to attachment pages by default.#12124
Conversation
Member
Author
|
@macmanx2 Do you think you could test this on your own site with the Beta plugin? Thank you! |
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: May 14, 2019. |
Contributor
|
On a meetup this week, but I think I can slice in some time to check. |
Fixes #12115 If one wishes to enable Related Posts on attachment pages, they will need to use the jetpack_relatedposts_filter_enabled_for_request filter.
f6d5e27 to
4b7b8c7
Compare
kraftbj
approved these changes
May 14, 2019
Contributor
|
@jeherve You good with the WP.com side? |
Contributor
|
Caution: This PR has changes that must be merged to WordPress.com |
jeherve
added a commit
that referenced
this pull request
May 27, 2019
* Kick off the changelog * Add 7.3.1 * Update date and post link * changelog: add #12219 * changelog: add #12170 * changelog: add #12184 * Changelog: add #12268 * Changelog: add #12081 * Changelog: add #12323 * Changelog: add #12204 * Changelog: add #12269 * Changelog: add #12332 * changelog: add #12339 * changelog: add #12209 * Changelog: add #12319 * Changelog: add #12357 * Changelog: add #12124 * Changelog: add #12373 * Changelog: add #12252 * Changelog: add #12383 * Changelog: add #12372 * changelog: add #12337 * Changelog: add #12290 * Changelog: add #12301 * Changelog: add #12061 * Testing list: add instructions for #12061 * Changelog: add #12393 * Update minimum supported version See #12287 * Changelog: add #12406 * Testing list: add #12406 * Changelog: add #12277 * Changelog: add #12412 * Changelog: add #11318 * Changelog: add #12328 * Changelog: add #12425 * Changelog: add #12380 * Changelog: add #12428 * Changelog: add #12414 * Changelog: add #12395 * Changelog & Testing list: add #12416, #12417, #12418, and #12348 * changelog: add #12379 * Changelog: add #12341 * changelog: add #12444 * Changelog: add #12434 * Changelog: add #12454 * Changelog: add #12460 * Changelog: add #12463 * Changelog: add #12457 * Changelog / testing list: add #10333 * Changelog: add #12467 Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12115
Changes proposed in this Pull Request:
is_singleusually returns true for attachments, although it should not. This additional check should solve the issue mentioned in #12115.If one wishes to enable Related Posts on attachment pages,
they will need to use the
jetpack_relatedposts_filter_enabled_for_requestfilter.Testing instructions:
Start on a site without this patch, where Related Posts are enabled and working, and where the following toggle is enabled under Appearance > Customize > Related Posts.
Go to Media > Library on a site
Click on "View" below one of your images.
Notice the "Related" header, but no actual related posts.
Check out this branch.
Notice that the Related header disappears from attachment pages, but not from regular posts.
Proposed changelog entry for your changes: