Skip to content

Business Hours: Simplify hours format#12406

Merged
thomasguillot merged 2 commits intomasterfrom
update/business-hours-time-format
May 20, 2019
Merged

Business Hours: Simplify hours format#12406
thomasguillot merged 2 commits intomasterfrom
update/business-hours-time-format

Conversation

@thomasguillot
Copy link
Copy Markdown
Contributor

@thomasguillot thomasguillot commented May 17, 2019

Simpler format for the hours, not having to rely on translations, with the use of a dash rather than "From [...] to".

Changes proposed in this Pull Request:

  • Remove the repetitious "From [...] to"
  • Simply use a dash to differentiate opening to closing hours
  • Update editor view to make sure multiple hours for the same day are on a separate line

See #12393

Testing instructions:

  • Add a Business Hours block to any post and page
  • Notice the new format in the editor
  • Notice the new format on the front-end

Before:

1 before
Editor / Front-end (Shoreditch)

After:

2 after
Editor / Front-end (Shoreditch)

Proposed changelog entry for your changes:

  • Business Hours: Simplify hours format

@thomasguillot
Business Hours: Simplify time format
be2529b 
* Remove the repetitious "From [...] to"
* Simply use a dash to differenciate opening to closing hours
* Update editor view to make sure multiple hours for the same day are on a separate line
@thomasguillot thomasguillot added Touches WP.com Files [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Business Hours labels May 17, 2019
@thomasguillot thomasguillot requested review from a team, jeherve and shaunandrews May 17, 2019 13:59
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented May 17, 2019

Caution: This PR has changes that must be merged to WordPress.com
Hello thomasguillot! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D28364-code before merging this PR. Thank you!

@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented May 17, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against b3b1bfc

@thomasguillot thomasguillot added the [Status] Needs Review This PR is ready for review. label May 17, 2019
@shaunandrews
Copy link
Copy Markdown
Contributor

shaunandrews commented May 17, 2019

I dig it.

@jeherve jeherve added this to the 7.4 milestone May 17, 2019
simison
simison reviewed May 20, 2019
View reviewed changes
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented May 20, 2019

thomasguillot, Your synced wpcom patch D28364-code has been updated.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 20, 2019
jeherve
jeherve approved these changes May 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@thomasguillot thomasguillot merged commit 87afd78 into master May 20, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 20, 2019
@thomasguillot thomasguillot deleted the update/business-hours-time-format branch May 20, 2019 13:27
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
Changelog: add #12406
816c8e8
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
Testing list: add #12406
1986991
jeherve added a commit that referenced this pull request May 27, 2019
@kraftbj @jeherve
7.4 Changelog (#12304)
0fb4436 
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simison simison simison left review comments

@jeherve jeherve jeherve approved these changes

@shaunandrews shaunandrews Awaiting requested review from shaunandrews

Assignees

No one assigned

Labels

[Block] Business Hours [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal Touches WP.com Files

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

6 participants

@thomasguillot @matticbot @jetpackbot @shaunandrews @simison @jeherve