Skip to content

Memberships: renewal period more visible#12418

Merged
artpi merged 4 commits intomasterfrom
memberships/renewal-periods-in-list
May 22, 2019
Merged

Memberships: renewal period more visible#12418
artpi merged 4 commits intomasterfrom
memberships/renewal-periods-in-list

Conversation

@artpi
Copy link
Copy Markdown
Contributor

@artpi artpi commented May 20, 2019

@rantoncuadrado has mentioned in beta testing, that renewal periods are not always clear.

This PR surfaces them

Zrzut ekranu 2019-05-20 o 18 34 59

Testing instructions

well, use the block

@artpi artpi added the [Status] Needs Review This PR is ready for review. label May 20, 2019
@artpi artpi requested review from a team and davemart-in May 20, 2019 16:38
@artpi artpi self-assigned this May 20, 2019
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented May 20, 2019

Caution: This PR has changes that must be merged to WordPress.com
Hello artpi! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D28441-code before merging this PR. Thank you!

@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented May 20, 2019 •
edited
Loading

Warnings
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 7d84205

@jeherve jeherve added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Block] Payment Button aka Recurring Payments labels May 20, 2019
jeherve
jeherve requested changes May 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few comments.

Unrelated, but while testing I also noticed that the currency did not seem to be displayed accordingly:

Screen Recording 2019-05-20 at 07 47 PM

@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels May 20, 2019
davemart-in
davemart-in previously approved these changes May 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@davemart-in davemart-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, I like it! 🚀

@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented May 21, 2019

artpi, Your synced wpcom patch D28441-code has been updated.

1 similar comment
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented May 21, 2019

artpi, Your synced wpcom patch D28441-code has been updated.

@artpi
Copy link
Copy Markdown
Contributor Author

artpi commented May 21, 2019 •
edited
Loading

Unrelated, but while testing I also noticed that the currency did not seem to be displayed accordingly:

Nice catch, Thank you! We gotta fix it. Ill note that in Trello.
fixed in e54f334

@artpi artpi added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 21, 2019
@artpi artpi requested a review from jeherve May 21, 2019 04:47
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented May 21, 2019

artpi, Your synced wpcom patch D28441-code has been updated.

@jeherve jeherve added this to the 7.4 milestone May 21, 2019
jeherve
jeherve previously approved these changes May 21, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well form me. Merge when ready.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 21, 2019
artpi and others added 4 commits May 22, 2019 17:00
@artpi artpi force-pushed the memberships/renewal-periods-in-list branch from e54f334 to 7d84205 Compare May 22, 2019 15:01
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented May 22, 2019

artpi, Your synced wpcom patch D28441-code has been updated.

@artpi artpi merged commit b4333ca into master May 22, 2019
@artpi artpi deleted the memberships/renewal-periods-in-list branch May 22, 2019 15:17
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 22, 2019
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
Changelog & Testing list: add #12416, #12417, #12418, and #12348
118adef
jeherve added a commit that referenced this pull request May 27, 2019
@kraftbj @jeherve
7.4 Changelog (#12304)
0fb4436 
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

@davemart-in davemart-in davemart-in left review comments

Assignees

@artpi artpi

Labels

[Block] Payment Button aka Recurring Payments Enhancement Changes to an existing feature — removing, adding, or changing parts of it Touches WP.com Files

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

5 participants

@artpi @matticbot @jetpackbot @jeherve @davemart-in