My plan: Add checklist progress banner by sirreal · Pull Request #12277 · Automattic/jetpack

sirreal · 2019-05-06T17:42:12Z

Prepare checklist UI for the My Plan page:

The checklist is not visible, #12404 will make the checklist functional

The data layer is in place, but no API calls are made. Endpoints in Jetpack and WordPress.com need to be prepared. Watch #12404 for work there.

Part of Automattic/wp-calypso#32565

Testing

Builds 👍
No changes at /wp-admin/admin.php?page=jetpack#/my-plan 👍
~~Does the link to Calypso work and direct you to the My Plan page in Calypso?~~

_inc/client/scss/style.scss

matticbot · 2019-05-08T10:02:51Z

Caution: This PR has changes that must be merged to WordPress.com
Hello sirreal! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D27964-code before merging this PR. Thank you!

jetpackbot · 2019-05-08T10:38:15Z

	Warnings
⚠️	"Testing instructions" are missing for this PR. Please add some
⚠️	"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 6a8779b

.eslintrc.js

_inc/client/my-plan/checklist-progress-card/index.js

_inc/client/my-plan/checklist-progress-card/progress-bar/screen-reader-text/style.scss

_inc/client/my-plan/checklist-progress-card/progress-bar/style.scss

_inc/client/my-plan/checklist-progress-card/style.scss

webpack.config.js

sirreal · 2019-05-08T16:40:26Z

Rebased to fix conflict

matticbot · 2019-05-08T16:40:30Z

sirreal, Your synced wpcom patch D27964-code has been updated.

checklist progress card: adjusting mobile styles for smaller screens

Checklist API requires WPCOM-side work. Disable and remove the data fetching for now.

jeherve

This looks good to me. 👍

sirreal · 2019-05-20T12:24:04Z

r191989-wpcom

* Kick off the changelog * Add 7.3.1 * Update date and post link * changelog: add #12219 * changelog: add #12170 * changelog: add #12184 * Changelog: add #12268 * Changelog: add #12081 * Changelog: add #12323 * Changelog: add #12204 * Changelog: add #12269 * Changelog: add #12332 * changelog: add #12339 * changelog: add #12209 * Changelog: add #12319 * Changelog: add #12357 * Changelog: add #12124 * Changelog: add #12373 * Changelog: add #12252 * Changelog: add #12383 * Changelog: add #12372 * changelog: add #12337 * Changelog: add #12290 * Changelog: add #12301 * Changelog: add #12061 * Testing list: add instructions for #12061 * Changelog: add #12393 * Update minimum supported version See #12287 * Changelog: add #12406 * Testing list: add #12406 * Changelog: add #12277 * Changelog: add #12412 * Changelog: add #11318 * Changelog: add #12328 * Changelog: add #12425 * Changelog: add #12380 * Changelog: add #12428 * Changelog: add #12414 * Changelog: add #12395 * Changelog & Testing list: add #12416, #12417, #12418, and #12348 * changelog: add #12379 * Changelog: add #12341 * changelog: add #12444 * Changelog: add #12434 * Changelog: add #12454 * Changelog: add #12460 * Changelog: add #12463 * Changelog: add #12457 * Changelog / testing list: add #10333 * Changelog: add #12467 Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>

sirreal · 2020-02-04T10:40:04Z

I've closed #12404 with no plans to continue.

It's possible that several files added here are completely unused and can be safely removed. It should be relatively straightforward cleanup.

FYI: @Automattic/jetpack-crew

jeherve · 2020-02-10T13:37:06Z

It's possible that several files added here are completely unused and can be safely removed. It should be relatively straightforward cleanup.

Logged in #14620.

jeffgolenski · 2020-02-10T16:16:47Z

Thanks for keeping an eye on this y'all.

Just cc'ing the design team so they know it exists. We may revisit in the future: @keoshi @crunnells @eeeeevon13 @folletto

In #12277 and #12429, we added a "checklist" component to the Jetpack dashboard, as well as a CTA that would lead you to the checklist in Calypso. We never really expanded on that checklist and its display in the React dashboard, but we now have a Recommendations component we use in Jetpack, since #18437. This commit removes the elements from the checklist that we never used, and updates the CTA link in "My Plan" to point to the new Recommendations, when those recommendations must be shown to site owners.

sirreal added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu Plans labels May 6, 2019

sirreal self-assigned this May 6, 2019

sirreal force-pushed the add/my-plan-checklist-progress branch 2 times, most recently from 099e69e to d82c23d Compare May 7, 2019 14:54

simison reviewed May 8, 2019

View reviewed changes

_inc/client/scss/style.scss Outdated Show resolved Hide resolved

matticbot added the Touches WP.com Files label May 8, 2019

sirreal force-pushed the add/my-plan-checklist-progress branch from f527388 to 97cd181 Compare May 8, 2019 10:35

sirreal added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels May 8, 2019

sirreal marked this pull request as ready for review May 8, 2019 10:36

sirreal requested a review from a team May 8, 2019 10:36

sirreal requested a review from a team May 8, 2019 10:39

simison reviewed May 8, 2019

View reviewed changes

.eslintrc.js Outdated Show resolved Hide resolved

simison reviewed May 8, 2019

View reviewed changes

_inc/client/my-plan/checklist-progress-card/index.js Outdated Show resolved Hide resolved

simison reviewed May 8, 2019

View reviewed changes

_inc/client/my-plan/checklist-progress-card/index.js Outdated Show resolved Hide resolved

simison reviewed May 8, 2019

View reviewed changes

_inc/client/my-plan/checklist-progress-card/progress-bar/screen-reader-text/style.scss Outdated Show resolved Hide resolved

simison reviewed May 8, 2019

View reviewed changes

_inc/client/my-plan/checklist-progress-card/progress-bar/style.scss Outdated Show resolved Hide resolved

simison reviewed May 8, 2019

View reviewed changes

_inc/client/my-plan/checklist-progress-card/style.scss Outdated Show resolved Hide resolved

simison reviewed May 8, 2019

View reviewed changes

webpack.config.js Outdated Show resolved Hide resolved

sirreal force-pushed the add/my-plan-checklist-progress branch from cec2ae2 to 21108a1 Compare May 8, 2019 16:40

sirreal mentioned this pull request May 8, 2019

Calypso build: Add changelog and bump to v2 Automattic/wp-calypso#32908

Merged

sirreal requested review from a team and jeffgolenski May 9, 2019 07:03

sirreal and others added 9 commits May 20, 2019 12:45

Remove style imports

498fdd8

Implement API for checklist

7ee7768

checklist progress card: adjusting mobile styles

7602bec

checklist progress card: adjusting mobile styles for smaller screens

Hide the card when empty

0112ead

Add completed/total selector

66d7aaf

Remove checklist API pieces

e727f2e

Checklist API requires WPCOM-side work. Disable and remove the data fetching for now.

Remove screen-reader-text styles (use core)

266fc04

Move to ScreenReaderText to shared components

bfce242

Simplify and make progress-bar specific

6a8779b

sirreal force-pushed the add/my-plan-checklist-progress branch from b6e11cd to 6a8779b Compare May 20, 2019 11:14

jeherve approved these changes May 20, 2019

View reviewed changes

jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 20, 2019

sirreal merged commit b9728ae into master May 20, 2019

matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 20, 2019

sirreal deleted the add/my-plan-checklist-progress branch May 20, 2019 11:56

jeherve added this to the 7.4 milestone May 20, 2019

jeherve added [Status] Has Changelog and removed [Status] Needs Changelog labels May 23, 2019

sirreal mentioned this pull request May 23, 2019

Analytics: Add tracks to checklist CTAs #12449

Merged

jeherve added a commit that referenced this pull request May 23, 2019

Changelog: add #12277

74755c0

jeherve mentioned this pull request Feb 10, 2020

Admin Page / Plans: remove checklist code #14620

Open

jeherve mentioned this pull request Feb 16, 2021

Recommendations: update button in My Plan to go to Recommendations #18843

Merged

Conversation

sirreal commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

Uh oh!

matticbot commented May 8, 2019

Uh oh!

jetpackbot commented May 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sirreal commented May 8, 2019

Uh oh!

matticbot commented May 8, 2019

Uh oh!

jeherve left a comment

Choose a reason for hiding this comment

Uh oh!

sirreal commented May 20, 2019

Uh oh!

sirreal commented Feb 4, 2020

Uh oh!

jeherve commented Feb 10, 2020

Uh oh!

jeffgolenski commented Feb 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sirreal commented May 6, 2019 •

edited

Loading

jetpackbot commented May 8, 2019 •

edited

Loading