Skip to content

Remove admin menu toggle in new post screen#12337

Merged
scottsweb merged 4 commits intomasterfrom
fix/admin-hamburger-in-gutenberg
May 16, 2019
Merged

Remove admin menu toggle in new post screen#12337
scottsweb merged 4 commits intomasterfrom
fix/admin-hamburger-in-gutenberg

Conversation

@scottsweb
Copy link
Copy Markdown
Contributor

@scottsweb scottsweb commented May 10, 2019

This is a little heavy handed but with so little space on narrow screens, I think it is probably best to remove the hamburger menu and go vegan in order to resolve the visual issues we are seeing:

Fixes #12320

Changes proposed in this Pull Request:

  • Hide the admin menu toggle in the Gutenberg editor

Testing instructions:

  • Activate the WordPress.com toolbar feature.
  • On mobile, go to Posts > Add New
  • You'll see the hamburger no longer interferes with the editor

Before:

57451783-84176d00-7262-11e9-88e0-54d2b2d0f093

After:

Screenshot 2019-05-10 at 14 51 48

Proposed changelog entry for your changes:

  • None, CSS fix

@scottsweb scottsweb added Bug When a feature is broken and / or not performing as intended Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Status] Needs Design Review Design has been added. Needs a review! labels May 10, 2019
@scottsweb scottsweb requested a review from a team May 10, 2019 13:56
@jeherve
Copy link
Copy Markdown
Member

jeherve commented May 10, 2019

This breaks navigation, though; how do I get to other pages in my dashboard once this is gone?

@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented May 10, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 14, 2019.
Scheduled code freeze: May 7, 2019

Generated by 🚫 dangerJS against 13e5d8b

@scottsweb
Copy link
Copy Markdown
Contributor Author

scottsweb commented May 10, 2019

That is a very valid concern. I thought this only really applied to sites where Calypso was the primary editing environment, so using the (w) logo as the escape hatch back to Calypso.

Another option could be to remove the add new centre button (as we already on that screen). I will see how that looks.

@scottsweb
Copy link
Copy Markdown
Contributor Author

scottsweb commented May 10, 2019

Screenshot 2019-05-10 at 18 03 52

@jeherve can you try this approach and let me know how you get on, this removes the "add new" button from the middle (as we are on that screen) and the moves the hamburger menu up to the left (for Gutenberg only)

@jeherve jeherve added this to the 7.4 milestone May 13, 2019
@jeherve jeherve removed the [Status] Needs Review This PR is ready for review. label May 13, 2019
jeherve
jeherve approved these changes May 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, and it works well for me. I think this should be good to merge once we get a design review!

@MichaelArestad MichaelArestad self-requested a review May 15, 2019 18:49
MichaelArestad
MichaelArestad approved these changes May 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichaelArestad MichaelArestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. I also noticed the new post link at the top takes users into Calypso. They would have to add a post via the sidebar link to see this.

@MichaelArestad MichaelArestad added [Status] Design Review Complete [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Design Review Design has been added. Needs a review! labels May 15, 2019
@scottsweb
Copy link
Copy Markdown
Contributor Author

scottsweb commented May 16, 2019

Thanks for the review, that is a good point. It is very rare that this scenario would appear I think.

@scottsweb scottsweb merged commit 2a00b20 into master May 16, 2019
@scottsweb scottsweb deleted the fix/admin-hamburger-in-gutenberg branch May 16, 2019 08:49
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 16, 2019
jeherve added a commit that referenced this pull request May 17, 2019
@jeherve
changelog: add #12337
ff11828
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
changelog: add #12337
00feb9e
jeherve added a commit that referenced this pull request May 27, 2019
@kraftbj @jeherve
7.4 Changelog (#12304)
0fb4436 
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
@jeherve jeherve mentioned this pull request Mar 25, 2020
Closed
@eeeeevon13 eeeeevon13 mentioned this pull request Jun 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

+1 more reviewer

@MichaelArestad MichaelArestad MichaelArestad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@scottsweb scottsweb

Labels

Bug When a feature is broken and / or not performing as intended Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Design Review Complete

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

Masterbar: handle Hamburger menu when in block editor on mobile

5 participants

@scottsweb @jeherve @jetpackbot @MichaelArestad @matticbot