Skip to content

CLI: Add a new command that lets you remove the callback checksum across all sites on a network#12081

Merged
tyxla merged 19 commits intomasterfrom
add/remove-all-duplicate-sync-checksums
May 10, 2019
Merged

CLI: Add a new command that lets you remove the callback checksum across all sites on a network#12081
tyxla merged 19 commits intomasterfrom
add/remove-all-duplicate-sync-checksums

Conversation

@enejb
Copy link
Copy Markdown
Member

@enejb enejb commented Apr 17, 2019 •
edited by lezama
Loading

Currently some site experience a problem where we create numerous jetpack_callables_sync_checksum options being added because of sync.

This happens on old sites with old db schemas where option_name wasn't unique.

This PR provides a new wp cli command that helps remove the option that appears multiple times in the table.

Changes proposed in this Pull Request:

  • Adds a wp cli command that deletes the jetpack_callables_sync_checksum across all the sites on the network as well as on single sites.

Testing instructions:

  • Setup a multi site.
  • Create the option in the table multiple times. (This part is tricky since in newer wp install this is not possible)
  • Does remove all the instances of that option?

Proposed changelog entry for your changes:

  • A new wp cli command.

@enejb enejb added [Status] Needs Review This PR is ready for review. [Package] Sync labels Apr 17, 2019
@enejb enejb requested review from a team, kraftbj and lezama April 17, 2019 20:51
@enejb enejb self-assigned this Apr 17, 2019
@enejb enejb added this to the 7.3 milestone Apr 17, 2019
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Apr 17, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 14, 2019.
Scheduled code freeze: May 7, 2019

Generated by 🚫 dangerJS against c4d1908

@kraftbj kraftbj added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Jetpack CLI labels Apr 17, 2019
lezama
lezama reviewed Apr 17, 2019
View reviewed changes
lezama
lezama reviewed Apr 18, 2019
View reviewed changes
lezama
lezama reviewed Apr 18, 2019
View reviewed changes
@simison simison changed the title CLI: Add a new command that lets you remove the checksum acoss all sites CLI: Add a new command that lets you remove the checksum across all sites Apr 19, 2019
tyxla
tyxla reviewed Apr 22, 2019
View reviewed changes
@kraftbj kraftbj added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Apr 22, 2019
kraftbj
kraftbj previously requested changes Apr 22, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change needed to built-in help picks up the new option.

As mentioned in Slack, having a --dry-run option and able to feed in a specific number of sites to check would be nice.

@enejb enejb force-pushed the add/remove-all-duplicate-sync-checksums branch from aecf8bb to 2ef15d0 Compare April 22, 2019 20:46
@enejb enejb force-pushed the add/remove-all-duplicate-sync-checksums branch from 2ef15d0 to fa65b42 Compare April 22, 2019 20:46
@enejb enejb added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Apr 22, 2019
lezama
lezama reviewed Apr 23, 2019
View reviewed changes
tyxla
tyxla reviewed Apr 23, 2019
View reviewed changes
@kraftbj kraftbj added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Apr 23, 2019
@enejb
Copy link
Copy Markdown
Member Author

enejb commented May 9, 2019

@jeherve can you take another look?

lezama
lezama reviewed May 9, 2019
View reviewed changes
lezama
lezama reviewed May 9, 2019
View reviewed changes
lezama
lezama reviewed May 9, 2019
View reviewed changes
lezama
lezama reviewed May 9, 2019
View reviewed changes
lezama
lezama reviewed May 9, 2019
View reviewed changes
lezama
lezama reviewed May 9, 2019
View reviewed changes
lezama
lezama previously approved these changes May 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@lezama lezama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 IT

@enejb enejb dismissed jeherve’s stale review May 9, 2019 15:19

Addressed all of your feedback

@lezama lezama requested a review from jeherve May 9, 2019 15:23
@jeherve jeherve mentioned this pull request May 10, 2019
Merged
jeherve
jeherve approved these changes May 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Merge when ready!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 10, 2019
@tyxla tyxla merged commit 1b4d4d3 into master May 10, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 10, 2019
@tyxla tyxla deleted the add/remove-all-duplicate-sync-checksums branch May 10, 2019 08:09
jeherve added a commit that referenced this pull request May 17, 2019
@jeherve
Changelog: add #12081
5639ed4
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
Changelog: add #12081
b10bdf6
jeherve added a commit that referenced this pull request May 27, 2019
@kraftbj @jeherve
7.4 Changelog (#12304)
0fb4436 
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyxla tyxla tyxla left review comments

@jeherve jeherve jeherve approved these changes

@kraftbj kraftbj kraftbj left review comments

@lezama lezama lezama left review comments

+4 more reviewers

@aldavigdis aldavigdis aldavigdis left review comments

@zinigor zinigor zinigor left review comments

@roccotripaldi roccotripaldi roccotripaldi left review comments

@gititon gititon gititon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@enejb enejb

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Jetpack CLI [Package] Sync

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.