Skip to content

Display Posts Widget: Remove overly opinionated CSS#12290

Merged
scottsweb merged 1 commit intomasterfrom
fix/posts-widget-css
May 16, 2019
Merged

Display Posts Widget: Remove overly opinionated CSS#12290
scottsweb merged 1 commit intomasterfrom
fix/posts-widget-css

Conversation

@scottsweb
Copy link
Copy Markdown
Contributor

@scottsweb scottsweb commented May 7, 2019

We have some very opinionated CSS in the remote posts widget at the moment, in #1886 we were asked to remove the !important declarations, allowing themes greater control. I have gone a little further to ensure we inherit theme styles as much as possible.

I have done some basic testing the the twenty themes, most of these already supply custom CSS for the widget so there is not a great deal of change to be observed.

We could probably take this further and remove the margin values as well but I am reluctant to make too many changes in one sweep.

Fixes #1886

Changes proposed in this Pull Request:

  • The CSS has been simplified

Testing instructions:

  • Add "Display WordPress posts (Jetpack)" widget to a widget area
  • Complete the fields, along with a random selection of options
  • Observe the look and feel of the widget
  • Pull down this PR
  • Observe the look and feel of the widget

Are the differences a concern? Does the widget fit better or worse with the existing theme styles?

Proposed changelog entry for your changes:

  • Display Posts Widget: Remove overly opinionated CSS, please check your themes

@scottsweb scottsweb added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets [Status] Needs Design Review Design has been added. Needs a review! labels May 7, 2019
@scottsweb scottsweb requested a review from a team May 7, 2019 17:57
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented May 7, 2019

Caution: This PR has changes that must be merged to WordPress.com
Hello scottsweb! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D27937-code before merging this PR. Thank you!

@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented May 7, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against 41ac289

@scottsweb scottsweb added the [Status] Needs Review This PR is ready for review. label May 7, 2019
@kraftbj kraftbj added this to the 7.4 milestone May 14, 2019
kraftbj
kraftbj approved these changes May 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me and no obvious issue. Ready to merge once Design approves.

@kraftbj kraftbj removed the [Status] Needs Review This PR is ready for review. label May 14, 2019
@MichaelArestad
Copy link
Copy Markdown
Contributor

MichaelArestad commented May 15, 2019

Can you add some before/after screenshots?

@MichaelArestad MichaelArestad self-requested a review May 15, 2019 18:56
MichaelArestad
MichaelArestad approved these changes May 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichaelArestad MichaelArestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I think the odds of this change causing something to break are extremely low.

Before

image

After

image

@MichaelArestad MichaelArestad added [Status] Design Review Complete [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Design Review Design has been added. Needs a review! labels May 15, 2019
@scottsweb scottsweb merged commit b0b1890 into master May 16, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 16, 2019
@scottsweb scottsweb deleted the fix/posts-widget-css branch May 16, 2019 09:23
jeherve added a commit that referenced this pull request May 17, 2019
@jeherve
Changelog: add #12290
83ed90f
@jeherve jeherve mentioned this pull request May 20, 2019
Closed
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
Changelog: add #12290
fcec70b
jeherve added a commit that referenced this pull request May 27, 2019
@kraftbj @jeherve
7.4 Changelog (#12304)
0fb4436 
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

+1 more reviewer

@MichaelArestad MichaelArestad MichaelArestad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@scottsweb scottsweb

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets [Status] Design Review Complete Touches WP.com Files

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

Display Posts Widget: remove !important from CSS

6 participants

@scottsweb @matticbot @jetpackbot @MichaelArestad @kraftbj @jeherve