Ads Gutenblock: Add "Hide ad on mobile views" toggle#11644
Merged
Conversation
Contributor
|
Caution: This PR has changes that must be merged to WordPress.com |
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: April 2, 2019. |
Co-Authored-By: dbspringer <derekspringer@gmail.com>
Contributor
|
dbspringer, Your synced wpcom patch D25858-code has been updated. |
1 similar comment
Contributor
|
dbspringer, Your synced wpcom patch D25858-code has been updated. |
jeherve
approved these changes
Mar 21, 2019
Member
jeherve
left a comment
There was a problem hiding this comment.
This seems to work well for me. 👍
Contributor
|
Please test and commit on WP.com when you're ready @dbspringer D25858-code |
kraftbj
added a commit
that referenced
this pull request
Mar 25, 2019
kraftbj
added a commit
that referenced
this pull request
Mar 25, 2019
kraftbj
added a commit
that referenced
this pull request
Mar 27, 2019
* Initial Changelog for 7.2 * Testing list: add mention of IE11 testing * Initial Changelog for 7.2 * Testing list: add mention of IE11 testing * Add CL for #11224 * Add CL for #11426 * Add CL for #11442 * Add testing instructions for #11224 * Add CL for #11451 * Reclassify CL item * Add testing instructions for #11451 * Add CL for #11486 * Add CL for #11418 * Add CL for #11524 * Add CL and testing instructions for #11449 * Add CL for #11460 * Add CL for #11520 and #11582 * Add CL for #11531 * Add CL #11644 * Add testing instructions for #11644 * Add testing instructions for #11644 * Add CL for #11618 * Uniform changelog lines * CL #11679 * CL #11661 * CL #11654 * CL #11645 * CL #11643 * CL #11636 * CL #11635 and for other PHPCS commits * CL #11627 * CL #11626 * CL #11598 * CL #11596 * Remove nested items for shortcopy. I don't believe the detailed list is helpful * CL #11570 * CL #11569 * CL #11560 * CL #11558 * CL #11555 * CL #6704 * CL #11298 * CL #11324 * CL #11443 * CL #11484 * CL #11516 * CL #11529 * Expand Ads block enhancement CL item
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes a tall/wide ad unit makes sense on Desktop, but not a mobile impression. It makes sense to include an option to disable the ad on a mobile impression or replace it with one that's more mobile friendly.
Calypso PR: Automattic/wp-calypso#31608
Addresses: Automattic/wp-calypso#30870
Changes proposed in this Pull Request:
Testing instructions:
npx lerna bootstrap --concurrency=2 --scope '@automattic/jetpack-blocks'), and then compile blocks e.g.npx lerna run build --stream --scope='@automattic/jetpack-blocks' && rsync -a --delete packages/jetpack-blocks/dist/ ../jetpack/_inc/blocks/Hide ad on mobile viewsProposed changelog entry for your changes: