Ads Gutenblock: Add "Hide ad on mobile views" toggle#31608
Merged
dbspringer merged 1 commit intomasterfrom Mar 25, 2019
Merged
Conversation
Contributor
Member
|
@thomasguillot do you have time to help here with design review? cc @scruffian |
sirreal
reviewed
Mar 25, 2019
Member
sirreal
left a comment
There was a problem hiding this comment.
Code looks good and works well 👍
Let's get design review.
sirreal
approved these changes
Mar 25, 2019
thomasguillot
requested changes
Mar 25, 2019
Contributor
thomasguillot
left a comment
There was a problem hiding this comment.
Can we have the toggle outside and underneath the placeholder? Also left-aligned rather than centred.
Member
|
Are any of the comments good for follow up PR if this would need to be
merged today to make it in time for 7.2?
…On Mon, 25 Mar 2019, 16:23 Thomas Guillot, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Can we have the toggle outside and underneath the placeholder? Also
left-aligned rather than centred.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#31608 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFUgEsX_qeN8eTpttb8uQJcuUpjOW8Pks5vaNvpgaJpZM4cAXTI>
.
|
1cb1ddd to
83b1218
Compare
Member
Author
|
Is something like this what you're talking about @thomasguillot?
|
Placing control outside placeholder
87c0329 to
77a9116
Compare
Contributor
This look great but it could look even better if we remove "Advertisements" and "REPORT THIS AD". As is, it clashes a bit with the toggle (can be done in a separate PR) |
thomasguillot
approved these changes
Mar 25, 2019
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes a tall/wide ad unit makes sense on Desktop, but not a mobile impression. It makes sense to include an option to disable the ad on a mobile impression or replace it with one that's more mobile friendly.
Jetpack PR: Automattic/jetpack#11644
Addresses: #30870
Changes proposed in this Pull Request
Testing instructions
npx lerna run build --stream --scope='@automattic/jetpack-blocks' && rsync -a --delete packages/jetpack-blocks/dist/ ../jetpack/_inc/blocks/Hide ad on mobile viewsFixes #