Twenty Nineteen: Prevent Sharing Button Overlap#11531
Merged
jeherve merged 1 commit intoAutomattic:masterfrom Mar 22, 2019
Merged
Twenty Nineteen: Prevent Sharing Button Overlap#11531jeherve merged 1 commit intoAutomattic:masterfrom
jeherve merged 1 commit intoAutomattic:masterfrom
Conversation
Collaborator
This is automated check which relies on |
Contributor
|
@allancole Do you think you could do a quick look at this to confirm this is a fine way to handle this? |
Contributor
|
@kraftbj Yup, I don't see any problems with this change, and fixes the display bug on Safari and Chrome. |
Contributor
|
Caution: This PR has changes that must be merged to WordPress.com |
kraftbj
added a commit
that referenced
this pull request
Mar 27, 2019
* Initial Changelog for 7.2 * Testing list: add mention of IE11 testing * Initial Changelog for 7.2 * Testing list: add mention of IE11 testing * Add CL for #11224 * Add CL for #11426 * Add CL for #11442 * Add testing instructions for #11224 * Add CL for #11451 * Reclassify CL item * Add testing instructions for #11451 * Add CL for #11486 * Add CL for #11418 * Add CL for #11524 * Add CL and testing instructions for #11449 * Add CL for #11460 * Add CL for #11520 and #11582 * Add CL for #11531 * Add CL #11644 * Add testing instructions for #11644 * Add testing instructions for #11644 * Add CL for #11618 * Uniform changelog lines * CL #11679 * CL #11661 * CL #11654 * CL #11645 * CL #11643 * CL #11636 * CL #11635 and for other PHPCS commits * CL #11627 * CL #11626 * CL #11598 * CL #11596 * Remove nested items for shortcopy. I don't believe the detailed list is helpful * CL #11570 * CL #11569 * CL #11560 * CL #11558 * CL #11555 * CL #6704 * CL #11298 * CL #11324 * CL #11443 * CL #11484 * CL #11516 * CL #11529 * Expand Ads block enhancement CL item
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This removes some of the additional CSS added in the initial commit of this file with the sharing buttons. It's from the Twenty Sixteen file, where it makes sense to include due to the unique styling, but in the Twenty Nineteen theme, it causes an overlap. Instead, it feels better adding a margin-bottom of zero, otherwise there's an obscure gap just by completely removing it.
Testing instructions:
Before:
After:
Proposed changelog entry for your changes: