Shortcopy: modify jumpstarted features#11558
Conversation
3809c4c to
226a1b6
Compare
…ocus towards security and performance
226a1b6 to
dbf4e68
Compare
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: April 2, 2019. |
|
We probalby need to rebuild module headers after these changes |
keoshi
left a comment
There was a problem hiding this comment.
This worked beautifully for me, activating the following modules: Asset CDN, Image CDN, Lazy Images, Monitor, Secure Sign On, and Sitemaps.
🛳
|
Caution: This PR has changes that must be merged to WordPress.com |
|
@eliorivero I just pushed a commit with the changes after running |
|
Also I already deployed D25531-code to sync the code |
oskosk
left a comment
There was a problem hiding this comment.
When testing this PR, I noticed that some of the modules that are being removed from Jumpstart here were activated anyways...
After jumpstarting
- Contact Form was activated
- Gravatar Hovercards was activated Sharing was activated
- Subscriptions was activated
Althought the thing is that they were activated on connection, not by me clicking the Jumpstart button.
Should we remove Auto Activate: Yes from them ?
|
@oskosk that pretty much means that they were useless in Jumpstart before. This iteration we're not touching auto activated, so let's leave them as that. |
oskosk
left a comment
There was a problem hiding this comment.
LGTM works as expected if the modules are deactivated by hand before jumpstarting!
* Initial Changelog for 7.2 * Testing list: add mention of IE11 testing * Initial Changelog for 7.2 * Testing list: add mention of IE11 testing * Add CL for #11224 * Add CL for #11426 * Add CL for #11442 * Add testing instructions for #11224 * Add CL for #11451 * Reclassify CL item * Add testing instructions for #11451 * Add CL for #11486 * Add CL for #11418 * Add CL for #11524 * Add CL and testing instructions for #11449 * Add CL for #11460 * Add CL for #11520 and #11582 * Add CL for #11531 * Add CL #11644 * Add testing instructions for #11644 * Add testing instructions for #11644 * Add CL for #11618 * Uniform changelog lines * CL #11679 * CL #11661 * CL #11654 * CL #11645 * CL #11643 * CL #11636 * CL #11635 and for other PHPCS commits * CL #11627 * CL #11626 * CL #11598 * CL #11596 * Remove nested items for shortcopy. I don't believe the detailed list is helpful * CL #11570 * CL #11569 * CL #11560 * CL #11558 * CL #11555 * CL #6704 * CL #11298 * CL #11324 * CL #11443 * CL #11484 * CL #11516 * CL #11529 * Expand Ads block enhancement CL item
Until now, when first enabling sharing buttons (which was done automatically when connecting Jetpack to WordPress.com), no buttons were automatically set for you. You had to go to Settings > Sharing to set some buttons and decide where they would be displayed. Since we do not automatically activate the Sharing feature anymore (see #11558), it makes senses to add some default configuration (Facebook and Twitter buttons appearing on posts and pages) when you manually activate the feature.
Until now, when first enabling sharing buttons (which was done automatically when connecting Jetpack to WordPress.com), no buttons were automatically set for you. You had to go to Settings > Sharing to set some buttons and decide where they would be displayed. Since we do not automatically activate the Sharing feature anymore (see #11558), it makes senses to add some default configuration (Facebook and Twitter buttons appearing on posts and pages) when you manually activate the feature.
This PR updates the modules that will be activated when the user chooses to Jumpstart the site. This is part of the shift towards security and performance.
Fixes #11556
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes: