Fix height of Contact Info map iframe in AMP#11443
Merged
jeherve merged 2 commits intoAutomattic:masterfrom Mar 22, 2019
Merged
Fix height of Contact Info map iframe in AMP#11443jeherve merged 2 commits intoAutomattic:masterfrom
jeherve merged 2 commits intoAutomattic:masterfrom
Conversation
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: April 2, 2019. |
westonruter
commented
Mar 1, 2019
kraftbj
previously approved these changes
Mar 11, 2019
Contributor
kraftbj
left a comment
There was a problem hiding this comment.
Works for me as advertised and did not notice any adverse effects.
kraftbj
approved these changes
Mar 22, 2019
Contributor
|
Caution: This PR has changes that must be merged to WordPress.com |
jeherve
approved these changes
Mar 22, 2019
kraftbj
added a commit
that referenced
this pull request
Mar 27, 2019
* Initial Changelog for 7.2 * Testing list: add mention of IE11 testing * Initial Changelog for 7.2 * Testing list: add mention of IE11 testing * Add CL for #11224 * Add CL for #11426 * Add CL for #11442 * Add testing instructions for #11224 * Add CL for #11451 * Reclassify CL item * Add testing instructions for #11451 * Add CL for #11486 * Add CL for #11418 * Add CL for #11524 * Add CL and testing instructions for #11449 * Add CL for #11460 * Add CL for #11520 and #11582 * Add CL for #11531 * Add CL #11644 * Add testing instructions for #11644 * Add testing instructions for #11644 * Add CL for #11618 * Uniform changelog lines * CL #11679 * CL #11661 * CL #11654 * CL #11645 * CL #11643 * CL #11636 * CL #11635 and for other PHPCS commits * CL #11627 * CL #11626 * CL #11598 * CL #11596 * Remove nested items for shortcopy. I don't believe the detailed list is helpful * CL #11570 * CL #11569 * CL #11560 * CL #11558 * CL #11555 * CL #6704 * CL #11298 * CL #11324 * CL #11443 * CL #11484 * CL #11516 * CL #11529 * Expand Ads block enhancement CL item
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9730.
Changes proposed in this Pull Request:
Since AMP has built-in responsiveness, the Contact Info widget's map iframe with 600⨉216 dimensions can the actual height to be much less. For example, in Twenty Seventeen the sidebar is 325px wide. This results in the iframe being 117px high, since 325:117 has the same aspect ratio as 600:216. To fix, this PR explicitly uses AMP's
fixed-heightlayout for theamp-iframeso that the height will always be 216px with the width being responsive.Testing instructions:
?amp) and inmasterit should look erroneously as this (with less vertical height):The HTML markup for AMP should look like this (after ampproject/amp-wp#1913, without which the
iframeinside thenoscriptis also converted toamp-iframe):Proposed changelog entry for your changes: