Skip to content

Stats Widget: Update language when no hits or no response from API server#11486

Merged
kraftbj merged 1 commit intomasterfrom
update/no-hits-text
Mar 5, 2019
Merged

Stats Widget: Update language when no hits or no response from API server#11486
kraftbj merged 1 commit intomasterfrom
update/no-hits-text

Conversation

@kraftbj
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj commented Mar 5, 2019

Changes proposed in this Pull Request:

  • Updates the "no hits" text.

Testing instructions:

  • On a brand new site, add the blog stats widget and see "no hits" returned.
  • Apply patch, repeat.
  • Alternatively, ensure the Jetpack site is not able to contact public-api.wordpress.com and try again.

Note: There is five minutes of caching for successful API requests.

Proposed changelog entry for your changes:

  • None needed.

@kraftbj kraftbj added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets [Status] Needs Review This PR is ready for review. labels Mar 5, 2019
@kraftbj kraftbj added this to the 7.2 milestone Mar 5, 2019
@kraftbj kraftbj requested a review from a team March 5, 2019 20:22
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 5, 2019
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 🚢

@jetpackbot
Copy link
Copy Markdown
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 2, 2019.
Scheduled code freeze: March 26, 2019

Generated by 🚫 dangerJS against 973954b

@kraftbj kraftbj merged commit f2bd10f into master Mar 5, 2019
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 5, 2019
@kraftbj kraftbj deleted the update/no-hits-text branch March 5, 2019 21:24
kraftbj added a commit that referenced this pull request Mar 25, 2019
kraftbj added a commit that referenced this pull request Mar 27, 2019
* Initial Changelog for 7.2

* Testing list: add mention of IE11 testing

* Initial Changelog for 7.2

* Testing list: add mention of IE11 testing

* Add CL for #11224

* Add CL for #11426

* Add CL for #11442

* Add testing instructions for #11224

* Add CL for #11451

* Reclassify CL item

* Add testing instructions for #11451

* Add CL for #11486

* Add CL for #11418

* Add CL for #11524

* Add CL and testing instructions for #11449

* Add CL for #11460

* Add CL for #11520 and #11582

* Add CL for #11531

* Add CL #11644

* Add testing instructions for #11644

* Add testing instructions for #11644

* Add CL for #11618

* Uniform changelog lines

* CL #11679

* CL #11661

* CL #11654

* CL #11645

* CL #11643

* CL #11636

* CL #11635 and for other PHPCS commits

* CL #11627

* CL #11626

* CL #11598

* CL #11596

* Remove nested items for shortcopy. I don't believe the detailed list is helpful

* CL #11570

* CL #11569

* CL #11560

* CL #11558

* CL #11555

* CL #6704

* CL #11298

* CL #11324

* CL #11443

* CL #11484

* CL #11516

* CL #11529

* Expand Ads block enhancement CL item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants