Skip to content

Sharing: Updated WhatsApp url to track stats#11661

Merged
kraftbj merged 1 commit intomasterfrom
update/sharing-file
Mar 23, 2019
Merged

Sharing: Updated WhatsApp url to track stats#11661
kraftbj merged 1 commit intomasterfrom
update/sharing-file

Conversation

@enejb
Copy link
Copy Markdown
Member

@enejb enejb commented Mar 22, 2019

This PR brings Jetpack's code in sync with D25879-code

Just to note that we are not tracking anything stats here just bringing the code changes from the .com to the jetpack side.

Changes proposed in this Pull Request:

  • Pass the url now though a redirect. This brings it easier to track stats.

Testing instructions:

  • Add the WhatsApp code sharing button to your page or post.
  • Notice that it still works as expected.

Proposed changelog entry for your changes:

  • Updated WhatsApp to be more constant with the other sharing buttons.

@enejb
Updated Whatsapp url to track stats
efc7a9d 
This PR brings Jetpack's code in sync with D25879-code
@enejb enejb added [Feature] Sharing Post sharing, sharing buttons [Status] Needs Review This PR is ready for review. labels Mar 22, 2019
@enejb enejb added this to the 7.2 milestone Mar 22, 2019
@enejb enejb self-assigned this Mar 22, 2019
@enejb enejb requested review from a team and lezama March 22, 2019 20:54
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Mar 22, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 2, 2019.
Scheduled code freeze: March 26, 2019

Generated by 🚫 dangerJS against efc7a9d

jeherve
jeherve approved these changes Mar 22, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. 🚢 👍

@jeherve jeherve added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 22, 2019
@kraftbj kraftbj merged commit 0b4a693 into master Mar 23, 2019
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 23, 2019
@kraftbj kraftbj deleted the update/sharing-file branch March 23, 2019 04:36
kraftbj added a commit that referenced this pull request Mar 26, 2019
@kraftbj
CL #11661
1072a92
kraftbj added a commit that referenced this pull request Mar 27, 2019
@kraftbj
Add initial 7.2 changelog to master (#11690)
2227bfd 
* Initial Changelog for 7.2

* Testing list: add mention of IE11 testing

* Initial Changelog for 7.2

* Testing list: add mention of IE11 testing

* Add CL for #11224

* Add CL for #11426

* Add CL for #11442

* Add testing instructions for #11224

* Add CL for #11451

* Reclassify CL item

* Add testing instructions for #11451

* Add CL for #11486

* Add CL for #11418

* Add CL for #11524

* Add CL and testing instructions for #11449

* Add CL for #11460

* Add CL for #11520 and #11582

* Add CL for #11531

* Add CL #11644

* Add testing instructions for #11644

* Add testing instructions for #11644

* Add CL for #11618

* Uniform changelog lines

* CL #11679

* CL #11661

* CL #11654

* CL #11645

* CL #11643

* CL #11636

* CL #11635 and for other PHPCS commits

* CL #11627

* CL #11626

* CL #11598

* CL #11596

* Remove nested items for shortcopy. I don't believe the detailed list is helpful

* CL #11570

* CL #11569

* CL #11560

* CL #11558

* CL #11555

* CL #6704

* CL #11298

* CL #11324

* CL #11443

* CL #11484

* CL #11516

* CL #11529

* Expand Ads block enhancement CL item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

@lezama lezama Awaiting requested review from lezama

Assignees

@enejb enejb

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Sharing Post sharing, sharing buttons Touches WP.com Files

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

5 participants

@enejb @jetpackbot @jeherve @kraftbj @matticbot