1.24.0 Release -> Master by marecar3 · Pull Request #2025 · wordpress-mobile/gutenberg-mobile

marecar3 · 2020-03-17T10:31:41Z

Release for Gutenberg Mobile v1.24.0

Related PRs

Gutenberg: Merge changes from mobile v1.24.0 to master WordPress/gutenberg#21041
WPAndroid: Gutenberg: update to v1.24.0 WordPress-Android#11454
WPiOS: Update to Gutenberg v1.24.0 WordPress-iOS#13672
Aztec-iOS: Prepare release 1.17.0 AztecEditor-iOS#1272
Aztec-Android: N/A

Extra PRs that Landed After the Release Was Cut

Fix check for file urls #2032 Media upload retry issues
Issue/fix spacer max #2030 Settings: Height range extends if Spacer comes from the web is higher than 500px
Fix: Fix Gallery caption overlapped by other block #2033 Gallery Caption is overlapped by the next block.
Disable Cover Block for Production #2028 Disable Cover block for production
Add support to Categories as part of the API fetch methods #2039 Add support to Categories as part of the API fetch methods

Changes

#1931 New block: Latest Posts
#1953 Fix Quote block's left border not being visible in Dark Mode
#1987 Added Starter Page Templates: when you create a new page, we now show you a few templates to get started more quickly.
#1964 Fix crash when pasting HTML content with embeded images on paragraphs

PR Submission Checklist

I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Test plan

Use the main WP apps to test the changes above. See WPAndroid and WPiOS PRs if there are specific tests to run.
Smoke test the main WP apps for general writing flow.

This reverts commit 9d45f09.

…e into add/cover-block # Conflicts: # gutenberg

…older" This reverts commit 28782d3.

iOS 13.0 on SauceLabs and 13.3 locally.

* improve test:e2e:ios:local, skip bundling on CI since we do it manualy * use already existing command * run preios before tests build and use --repo-update flag

…e-aztec-old-submodule Remove react-native-aztec-old-submodule

guarani · 2020-03-19T15:25:06Z

@marecar3 while retesting #2025 (comment) I can reproduce consistently an error where image URLs are saved as file:/// instead of https:// in Gallery TC008. When this happens, the images stay slightly blurry and tapping on them reveals an iOS action sheet with no options (just a title).

I reproduced it on about 3 of 4 attempts with this particular test (Gallery TC008). I ran similar tests such as TC005 and TC007 twice each and I didn't come across this error.

chipsnyder · 2020-03-19T15:28:19Z

It looks like WordPress/gutenberg#20832 broke the Latest-Posts Block. Working on a fix for that now.

Edit PR Created #2039

…le_urls Fix check for file urls

chipsnyder · 2020-03-19T22:07:38Z

RE: #2025 (comment)
Just merged the PRs for this:
WordPress/gutenberg#21025 -> 8017d0f3526015529f20067b57c67953a9980bdd

#2039 -> cec2df78aa674084e57870e007a1858076ab2ecb

cameronvoell · 2020-03-19T22:28:18Z

marecar3 · 2020-03-20T09:17:47Z

@marecar3 while retesting #2025 (comment) I can reproduce consistently an error where image URLs are saved as file:/// instead of https:// in Gallery TC008. When this happens, the images stay slightly blurry and tapping on them reveals an iOS action sheet with no options (just a title).

I reproduced it on about 3 of 4 attempts with this particular test (Gallery TC008). I ran similar tests such as TC005 and TC007 twice each and I didn't come across this error.

Nice work @guarani!!! Thanks for finding this one!

Adding comment from @geriux :
Well, this is not related to the other URL issues. This bug is still happening but I’m not sure if its a blocker or not. Since its a case when the user closes and opens the editor while uploading images to a gallery

if the editor is opened it works fine, but if you close and open several times with a few images uploading some fail

as Paul reported

What do you think @pinarol on this one, is it a blocker?

pinarol · 2020-03-20T10:05:08Z

hi @marecar3 👋 I don’t think that’s a blocker, you need to close/open several times to repro that. Our download completion mechanism is not perfect, I bet this was working like this from the beginning. Could you open a separate issue for this and put in Mobile Gutenpages board? Thank you!

marecar3 · 2020-03-20T10:35:49Z

hi @marecar3 👋 I don’t think that’s a blocker, you need to close/open several times to repro that. Our download completion mechanism is not perfect, I bet this was working like this from the beginning. Could you open a separate issue for this and put in Mobile Gutenpages board? Thank you!

Thanks, @pinarol! I have raised an issue: #2041
Let me know if I need to update something on it.

mchowning

Tested all the changes, including the ones that landed after the branch was cut, and everything looks good to me. 👍

cameronvoell · 2020-03-20T19:05:05Z

With Dark mode merged I'm seeing an issue where I can't scroll up on a longer post after opening and closing the keyboard of a paragraph block. Hard to see the screen twitch while I try and scroll in my low frame rate GIF, but that's what's happening. I'm testing now to see if this issue is isolated to the Post-Dark mode version of the release.

Steps:

on a longer post that allows scrolling, add a paragraph block at the bottom
let the keyboard open for input on a paragraph block at the bottom of a long post
then hit back to close the keyboard
try and scroll back up, it sort of jumps and doesn’t let you scroll up until you try multiple times. Worse in landscape mode.

marecar3 · 2020-03-20T19:09:34Z

With Dark mode merged I'm seeing an issue where I can't scroll up on a longer post after opening and closing the keyboard of a paragraph block. Hard to see the screen twitch while I try and scroll in my low frame rate GIF, but that's what's happening. I'm testing now to see if this issue is isolated to the Post-Dark mode version of the release.

Steps:

on a longer post that allows scrolling, add a paragraph block at the bottom

let the keyboard open for input on a paragraph block at the bottom of a long post

then hit back to close the keyboard

try and scroll back up, it sort of jumps and doesn’t let you scroll up until you try multiple times. Worse in landscape mode.

Nice job @cameronvoell!
I also can reproduce this one on my device: Pixel 3, Android 10.

guarani · 2020-03-20T19:39:17Z

I'm seeing a reasonably reproducible crash (75%) on iOS when adding both an image and a video to a post.

Add an image block and choose an image from the device (preferably a high-res one, as that seems to help reproduce this crash)
Add a video (I chose to record a ~5 second video)
After recording the video and tapping "Use Video", the app crashes

iPhone 7, iOS 13.3.1 and WordPress build 25203

hypest · 2020-03-20T19:52:59Z

👋 @guarani , can you also check if the issue is there for you on the original/earliest build for the release and also on the previous release, to try and pinpoint if this is a new issue or not? Thanks!

guarani · 2020-06-16T13:52:06Z

I'm seeing a reasonably reproducible crash (75%) on iOS when adding both an image and a video to a post.

This issue was fixed via wordpress-mobile/WordPress-iOS#14299

Gerardo Pacheco and others added 30 commits January 17, 2020 15:42

Update Gutenberg ref

dd7e8c9

Add Cover block example

745ed45

Update Gutenberg ref

e5df292

Merge with develop

dca7bcf

Update Gutenberg ref

35560f7

Update gutenberg ref

7c88bd1

Symlink use select

9d45f09

Revert "Symlink use select"

c96213c

This reverts commit 9d45f09.

Merge branch 'develop' of github.com:wordpress-mobile/gutenberg-mobil…

3db2fe2

…e into add/cover-block # Conflicts: # gutenberg

Update Gutenberg ref

99c6248

Merge branch 'develop' of github.com:wordpress-mobile/gutenberg-mobil…

24d3759

…e into add/cover-block # Conflicts: # gutenberg

Update Gutenberg ref

3a17b2e

Update Gutenberg ref

62cce02

Merge branch 'develop' of github.com:wordpress-mobile/gutenberg-mobil…

d10d332

…e into add/cover-block # Conflicts: # gutenberg

Bundles for testing

d0778b4

Remove react-native-aztec-old-submodule

c972d0d

Update Gutenberg ref

f49d1c4

Add Jitpack step to remove react-native-aztec-old-submodule folder

28782d3

Revert "Add Jitpack step to remove react-native-aztec-old-submodule f…

7fc0552

…older" This reverts commit 28782d3.

Add step to Jitpack config removing react-native-aztec-old-submodule

e85de8b

Update Gutenberg ref

261d8f1

Update Gutenberg ref

6a9a2c0

Update Gutenberg ref

9311cab

Update Gutenberg ref

3b99fd1

Update Gutenberg ref

b007b64

Revert bundles

db728c5

Updates versions of iOS to run tests to iOS 13

43b5e10

iOS 13.0 on SauceLabs and 13.3 locally.

[e2e] improve e2e iOS tests (#1649)

6c67d47

* improve test:e2e:ios:local, skip bundling on CI since we do it manualy * use already existing command * run preios before tests build and use --repo-update flag

Merge branch 'develop' into fix/e2e-update-ios-simulators-versions

4a004da

Merge pull request #1861 from wordpress-mobile/try/remove-react-nativ…

2f627a9

…e-aztec-old-submodule Remove react-native-aztec-old-submodule

marecar3 and others added 3 commits March 19, 2020 12:00

Update gb reference

97ffd77

Update GB reference.

adbd7d1

Update bundle

69f4ac1

Merge pull request #2032 from wordpress-mobile/issue/fix_check_for_fi…

60f54ed

…le_urls Fix check for file urls

marecar3 added 3 commits March 20, 2020 10:23

Update gb reference

516218d

cherry pick from api fetch PR

0089260

Update bundle files

90a3633

This was referenced Mar 20, 2020

Merge changes from mobile v1.24.0 to master WordPress/gutenberg#21041

Merged

Invalid image URL after Close/Re-opening Gallery multiple times during upload of multiple images #2041

Closed

mchowning approved these changes Mar 20, 2020

View reviewed changes

marecar3 added 2 commits March 20, 2020 15:12

Cherry pick - dark mode implementation

8b3be07

Update bundle files

841b8c7

marecar3 added 2 commits March 20, 2020 20:32

Update gutenberg reference

8d80fc0

Revert dark mode on Android

f6c426d

khaykov mentioned this pull request Mar 20, 2020

Revert "Feature/material theme and Dark Theme support" wordpress-mobile/WordPress-Android#11486

Merged

Update bundle files

462d971

cameronvoell merged commit d584f8d into master Mar 20, 2020

Tug deleted the release/1.24.0 branch March 28, 2020 12:13

Conversation

marecar3 commented Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

PR Submission Checklist

Test plan

Uh oh!

guarani commented Mar 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chipsnyder commented Mar 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chipsnyder commented Mar 19, 2020

Uh oh!

cameronvoell commented Mar 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marecar3 commented Mar 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pinarol commented Mar 20, 2020

Uh oh!

marecar3 commented Mar 20, 2020

Uh oh!

mchowning left a comment

Choose a reason for hiding this comment

Uh oh!

cameronvoell commented Mar 20, 2020

Uh oh!

marecar3 commented Mar 20, 2020

Uh oh!

guarani commented Mar 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hypest commented Mar 20, 2020

Uh oh!

guarani commented Jun 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

marecar3 commented Mar 17, 2020 •

edited

Loading

guarani commented Mar 19, 2020 •

edited

Loading

chipsnyder commented Mar 19, 2020 •

edited

Loading

cameronvoell commented Mar 19, 2020 •

edited

Loading

marecar3 commented Mar 20, 2020 •

edited

Loading

guarani commented Mar 20, 2020 •

edited

Loading