Conversation
|
@dratwas thanks for this! Do you mind to update with the latest develop? We just merged some changes that upgrade the version of Appium and some configuration and it will good to make sure these changes play well together. |
|
Hi @SergioEstevao sorry for the delay. Today I checked all my PRs and found this one. I updated it with the develop branch and should be still valid :) Could you please review it one more time? |
|
@dratwas Because we now are using CocodPods for the build process should we add: |
|
Yes! You're right it should be run before. Let me add it :) Btw. WDYT about changing the to use the Edit: Maybe we could do it even better. Change the and the |
SergioEstevao
left a comment
There was a problem hiding this comment.
Great work! Thanks for this!
I think we have a few redundant actions in
test:e2e:ios:local, they increase the time of build steps.the flow of script to run local e2e tests for iOS:
"test:e2e:ios:local": "yarn test:e2e:build-app:ios && yarn test:e2e:install-app:ios && TEST_RN_PLATFORM=ios yarn device-tests:local"yarn test:e2e:build-app:ios does:react-native run-iosscript with--no-packagerflag and--configuration Release(it builds JS bundle and copy it to the app in Build Phases script)react-native bundleone more time and copy it to the app (it is already there from step 1)cd ./ios/build/gutenberg/Build/Products/Release-iphonesimulator && zip -r $WORK_DIR/ios/Gutenberg.app.zip gutenberg.appit is needed only for CI to upload the app to the sauce labs (this scripts from package.json is not used in ci config https://github.com/wordpress-mobile/gutenberg-mobile/blob/develop/.circleci/config.yml#L137)yarn test:e2e:install-app:iosruns onlyyarn test:e2e:build-app:iosunder the hood, so basically runs steps 1, 2, 3 one more time.TEST_RN_PLATFORM=ios yarn device-tests:localruns appium testsI think we could make it much faster by removing points 2 and 3 from
yarn test:e2e:build-app:iosand remove theyarn test:e2e:install-app:iosSince we use caching of app builds on CI but we want to build JS bundle each time, I also set the flag
SKIP_BUNDLINGin CI config to skip creating of JS bundle during the build step. JS bundle is created in the next stepTo test:
ios/builddirectory (just to be sure)yarn test:e2e:ios:localUpdate release notes:
RELEASE-NOTES.txt.