Conversation
This was referenced Mar 9, 2020
pinarol
reviewed
Mar 9, 2020
| private func dummy() { | ||
| _ = NSLocalizedString("'%s' isn't yet supported on WordPress for Android", comment: "") | ||
| _ = NSLocalizedString("'%s' isn't yet supported on WordPress for iOS", comment: "") | ||
| _ = NSLocalizedString("(555)555-1234", comment: "translators: sample content for \"Contact\" page template") |
Contributor
There was a problem hiding this comment.
Is it expected that we don't see similar changes for Android?
Member
Author
There was a problem hiding this comment.
They're there in bundle/android/strings.xml, but GitHub has the bad habit of not showing some diffs by default, so it was easy to miss
This was referenced Mar 17, 2020
This was referenced May 15, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
__mobileEnablePageTemplatesfeature flags and enables page templates by default.Fixes #1962
gutenberg-mobile PR: #1987
gutenberg PR: WordPress/gutenberg#20718
WPiOS PR: wordpress-mobile/WordPress-iOS#13595
WPAndroid PR: wordpress-mobile/WordPress-Android#11409
To test:
From either WPiOS or WPAndroid, create a new page and verify that the template picker is showing
PR submission checklist:
RELEASE-NOTES.txtif necessary.