Skip to content

Enable page templates#13595

Closed
koke wants to merge 3 commits intodevelopfrom
enable-page-templates
Closed

Enable page templates#13595
koke wants to merge 3 commits intodevelopfrom
enable-page-templates

Conversation

@koke
Copy link
Copy Markdown
Member

@koke koke commented Mar 4, 2020 •
edited
Loading

This PR is only a helper to get installable builds, there's no need to merge these changes outside the regular Gutenberg release process.

gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1987
gutenberg PR: WordPress/gutenberg#20718
WPiOS PR: #13595
WPAndroid PR: wordpress-mobile/WordPress-Android#11409

To test:

Create a new page and verify that the template picker is showing

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Mar 4, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 24148. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2020 •
edited
Loading

Warnings
⚠️ PR is missing at least one label.

Generated by 🚫 dangerJS against e7680f3

This was referenced Mar 9, 2020
Merged
Merged
Closed
@koke koke requested review from iamthomasbishop and pinarol March 9, 2020 11:33
@koke koke added the Gutenberg Editing and display of Gutenberg blocks. label Mar 9, 2020
@koke koke added this to the 14.5 milestone Mar 9, 2020
@koke koke marked this pull request as ready for review March 9, 2020 11:33
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Mar 9, 2020

Warnings
⚠️ This PR is tagged with 'DO NOT MERGE'.

Generated by 🚫 dangerJS

@koke koke closed this Mar 13, 2020
@koke koke deleted the enable-page-templates branch March 13, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamthomasbishop iamthomasbishop Awaiting requested review from iamthomasbishop

@pinarol pinarol Awaiting requested review from pinarol

Assignees

No one assigned

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

14.5

Development

Successfully merging this pull request may close these issues.

1 participant

@koke