Skip to content

Issue/fix spacer max#2030

Merged
SergioEstevao merged 4 commits intorelease/1.24.0from
issue/fix_spacer_max
Mar 19, 2020
Merged

Issue/fix spacer max#2030
SergioEstevao merged 4 commits intorelease/1.24.0from
issue/fix_spacer_max

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Mar 18, 2020

Fix issue where spacers with more than 500 height were being resized automatically to 500 when opening settings

GB PR: WordPress/gutenberg#20984

To test:

  • Open the demo app
  • Add a spacer block
  • Switch to HTML mode
  • Change the height of the spacer to something larger than 500
  • Switch to visual mode
  • Open the setting of the block
  • Check that you can see the larger value and edit the value.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the [Type] Bug Something isn't working label Mar 18, 2020
@SergioEstevao SergioEstevao added this to the 1.24 milestone Mar 18, 2020
@SergioEstevao SergioEstevao deleted the issue/fix_spacer_max branch March 18, 2020 12:08
@SergioEstevao SergioEstevao restored the issue/fix_spacer_max branch March 18, 2020 12:08
@SergioEstevao SergioEstevao reopened this Mar 18, 2020
@SergioEstevao SergioEstevao changed the base branch from release/1.24.0 to develop March 18, 2020 17:28
@SergioEstevao SergioEstevao changed the base branch from develop to release/1.24.0 March 18, 2020 17:28
@SergioEstevao
Copy link
Copy Markdown
Contributor Author

Closed, this branch needs to retargeted to develop

@SergioEstevao SergioEstevao deleted the issue/fix_spacer_max branch March 18, 2020 17:33
@SergioEstevao SergioEstevao restored the issue/fix_spacer_max branch March 18, 2020 20:52
@SergioEstevao SergioEstevao reopened this Mar 18, 2020
@marecar3 marecar3 mentioned this pull request Mar 19, 2020
7 tasks
@SergioEstevao SergioEstevao merged commit b21c5db into release/1.24.0 Mar 19, 2020
@SergioEstevao SergioEstevao deleted the issue/fix_spacer_max branch March 19, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant