Rnmobile/fix spacer max#20984
Closed
SergioEstevao wants to merge 1 commit intornmobile/release-1.24.0from
Closed
Conversation
|
Size Change: +8 B (0%) Total Size: 857 kB
ℹ️ View Unchanged
|
2 tasks
lukewalczak
approved these changes
Mar 18, 2020
Member
|
It will be good to update TC005 according to that change |
Contributor
|
Just a side note, this was detected by wordpress-mobile/gutenberg-mobile#2025 (comment) @SergioEstevao Could you also update the test case here https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/spacer.md#tc005 ? no need for a PR, you can directly edit. |
Contributor
Author
|
Close this in favour of: #20986 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix scenarios where the spacer height is larger than the current max and we want to allow users to edit the value inside the range.
How has this been tested?
This can be tested on GB mobile here: wordpress-mobile/gutenberg-mobile#2030
Screenshots
Types of changes
Checklist: