Skip to content

Add support to Categories as part of the API fetch methods#2039

Merged
chipsnyder merged 2 commits intodevelopfrom
issue/2038-apiFetch
Mar 19, 2020
Merged

Add support to Categories as part of the API fetch methods#2039
chipsnyder merged 2 commits intodevelopfrom
issue/2038-apiFetch

Conversation

@chipsnyder
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder commented Mar 19, 2020 •
edited
Loading

Fixes: #2038

gutenberg: WordPress/gutenberg#21025

Description

API

Adjusts the fetching of categories from using fetchRequest to use apiFetch which also removed the need for casting the platform response and converting it to JSON for Android

QueryControls

WordPress/gutenberg#20832 Introduced an issue with Query Controls in order to maintain the stable state of these controls I cloned that file to index.native.js and removed the mobile-specific code in the old file. There seem to be a lot of planned changes there so we can probably reassess combining them later.

Style change

Resolved the issue mentioned here WordPress/gutenberg#20301 (comment)

How has this been tested?

Tested following the steps here: WordPress/gutenberg#20301

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added [Type] Enhancement Improves a current area of the editor bugfix [Type] Regression Existing functionality that got broken labels Mar 19, 2020
@chipsnyder chipsnyder added this to the 1.24 milestone Mar 19, 2020
This was referenced Mar 19, 2020
Merged
Merged
@SergioEstevao SergioEstevao changed the title Add support to Catgories as part of the API fetch methods Add support to Categories as part of the API fetch methods Mar 19, 2020
@chipsnyder chipsnyder changed the base branch from release/1.24.0 to develop March 19, 2020 17:47
@chipsnyder chipsnyder force-pushed the issue/2038-apiFetch branch from e323d92 to 28bf36b Compare March 19, 2020 17:51
@chipsnyder chipsnyder force-pushed the issue/2038-apiFetch branch from 28bf36b to ff76559 Compare March 19, 2020 17:54
SergioEstevao
SergioEstevao approved these changes Mar 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chipsnyder chipsnyder merged commit cec2df7 into develop Mar 19, 2020
@chipsnyder chipsnyder linked an issue Mar 19, 2020 that may be closed by this pull request
Update Latest-Post Block to fetch categories via the apiFecth API #2038
Closed
@SergioEstevao
Copy link
Copy Markdown
Contributor

SergioEstevao commented Mar 19, 2020

@marecar3 the change on this PR also needs to cherry picked for the release 1.24 branch.

@marecar3
Copy link
Copy Markdown
Contributor

marecar3 commented Mar 20, 2020

@marecar3 the change on this PR also needs to cherry picked for the release 1.24 branch.

Thanks, I will do it.

@marecar3 marecar3 deleted the issue/2038-apiFetch branch March 20, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees

No one assigned

Labels

bugfix [Type] Enhancement Improves a current area of the editor [Type] Regression Existing functionality that got broken

Projects

None yet

Milestone

1.24

Development

Successfully merging this pull request may close these issues.

Update Latest-Post Block to fetch categories via the apiFecth API

3 participants

@chipsnyder @SergioEstevao @marecar3