Skip to content

Fix check for file urls#2032

Merged
SergioEstevao merged 3 commits intorelease/1.24.0from
issue/fix_check_for_file_urls
Mar 19, 2020
Merged

Fix check for file urls#2032
SergioEstevao merged 3 commits intorelease/1.24.0from
issue/fix_check_for_file_urls

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Mar 18, 2020

This PR updates the GB reference for one that fixes the test for local file URL

To test:

  • Start the main app WPiOS or WPAndroid app using this branch for RN
  • Add an image/video/media block
  • Select some media to upload
  • Go offline while the upload is going
  • Wait for fail
  • Go online again
  • Check if retry options show when tapping on the block.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the [Type] Bug Something isn't working label Mar 18, 2020
@SergioEstevao SergioEstevao added this to the 1.24 milestone Mar 18, 2020
@SergioEstevao SergioEstevao requested review from geriux and pinarol March 18, 2020 12:00
geriux
geriux approved these changes Mar 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#20985 (review)

@marecar3 marecar3 mentioned this pull request Mar 19, 2020
Merged
7 tasks
@SergioEstevao SergioEstevao merged commit 60f54ed into release/1.24.0 Mar 19, 2020
@SergioEstevao SergioEstevao deleted the issue/fix_check_for_file_urls branch March 19, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinarol pinarol Awaiting requested review from pinarol

1 more reviewer

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Bug Something isn't working

Projects

None yet

Milestone

1.24

Development

Successfully merging this pull request may close these issues.

2 participants

@SergioEstevao @geriux