Latest Posts Block v1 Support in Mobile#1931
Conversation
2eb611c to
9f531c6
Compare
c359074 to
ec0771c
Compare
|
@chipsnyder Great work thus far! Per our discussion in Slack on Friday, I have some feedback. I see you've already made some changes and I've pulled down the latest build and I'll update my notes as a result 😄 I have only tested in iOS thus far, but I am assuming most of these issues also exist on Android. So I will give Android a good review on Monday. Relevant Issues
Unrelated issues
|
The default is
👍
Oops, those changes must not have made it in the build I'll double-check that they're included.
Yeah, I wasn't the biggest fan of the original wording either. These should all be straight forward changes. I'll get something together for you later today. Thanks for taking a look at the updated tweaks :) |
I just deleted and re-installed the test build and I'm seeing them now — not sure if this is an updated build or I just missed them in my second review All good now! 😄
Awesome, thank you! 🙏 |
2653b89 to
3032629
Compare
geriux
left a comment
There was a problem hiding this comment.
Approved via WordPress/gutenberg#20301 (review)
Fixes: #1746
Related PRs:
gutenberg[RNMobile] Latest Posts Block v1 Support in Mobile WordPress/gutenberg#20301WordPress-iOS[Testing] RNMobile Latest Posts Block WordPress-iOS#13495WordPress-Android[Testing] RNMobile Latest Posts Block WordPress-Android#11338To Test
These tests were validated via WPiOS and WPAndroid
Categories make a network request to fetch the available categories, so they were tested against a Wordpress.com site as well as a self-hosted site.
Add New Block
Expect: block to be added
Expect the settings to show
Validate the block is configured based on the settings in the table above
Modify Block
This should be tested by modifying in mobile and validating on the web and by modifying on the web and testing on mobile.
Conditional items:
Validate by checking the page on the other platform and by going into the same page/post that all settings match how you configured them.
Categories known behaviors
Categories are fetched in
componentDidMountwhich results in a flow where multiple Latest-Posts Blocks can show different data.- Take Note of the Categories -
- Note the first block does not reflect the changes in the categories -
- Note the second block does reflect the changes in the categories -
This behavior is consistent on the web and mobile. Leaving the page and coming back will sync the categories.
Screenshots
PR submission checklist:
RELEASE-NOTES.txtif necessary.