Remove react-native-aztec-old-submodule#1861
Conversation
|
Changes looks good to me. Could you maybe open a PR on WPAndroid that targets this branch to make sure ewverything is ok now? |
fc7493e to
c972d0d
Compare
|
Android PR builds failed with a JitPack error: https://jitpack.io/com/github/wordpress-mobile/gutenberg-mobile/fc7493eb81/build.log Tried rebasing but got the same error: @hypest maybe you have an idea? |
|
Looking at the JitPack log:
Looks like the "old-submodule" is still there. Not fully sure yet if this is essentially the same error that we got back in the day and that's why we decided to keep the old-submodule around 🤔 . |
|
Or, perhaps we have to add a step in JitPack's config to |
I think it was a different error before jitpack/jitpack.io#3707 mentioned here #486.
Let me try that 👍 |
|
It worked perfectly 🎉 Android build is now green as well: wordpress-mobile/WordPress-Android#11289 |
react-native-aztecwas moved into this repo a while ago and it's submodule was removed: #465But this submodule was re-introduced again because of JitPack problems: #486
Seems like JitPack is not an issue anymore as the CI is green in this PR so we can remove this submodule now.