Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
2 tasks
Feature was already released in 14.2
…elease-note Remove duplicate gallery image size release note
mchowning
commented
Feb 20, 2020
RELEASE-NOTES.txt
Outdated
| * Block editor: Added the Button block | ||
| * Block editor: Add scroll support inside block picker and block settings | ||
| * Block editor: Fix issue where adding emojis to the post title added strong HTML elements to the title of the post | ||
| * Block editor: Fix issue where alignment of paragraph blocks was not respected when splitting the paragraph or reading from the original Post content |
Contributor
Author
There was a problem hiding this comment.
👋 @SergioEstevao ! The "reading from the original Post content" part of this release note is a bit unclear to me. Wondering if we can improve that at all. If any better wording comes to mind feel free to update the release note here yourself. Or if you want to just leave a comment explaining a bit about what that means, I'll see if I can think of any improvements we could make. 🙇
Contributor
Author
|
I tested all the changes with the latest code (my gutenberg-mobile comment lists the specific tests I performed) and everything looks good to me. |
SergioEstevao
approved these changes
Feb 21, 2020
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
Tested the following things:
- Paragraph aligment
- Emoji on post title
- Upload on galleries
- Image align settings
- Large numbers ordered list
- General smoke test
This all looking it's a
for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1924
Changes
wordpress-mobile/gutenberg-mobile#1914 Fix menu item width inside the inserter
wordpress-mobile/gutenberg-mobile#1857 Update aztec to 1.16.0 (Fix display of large numbers in ordered lists)
wordpress-mobile/gutenberg-mobile#1918 Correct add icon appearance
wordpress-mobile/gutenberg-mobile#1904 Removing DEV flag for Image block size options
wordpress-mobile/gutenberg-mobile#1879 Fix link button on Rich Text
wordpress-mobile/gutenberg-mobile#1616 Button Block
wordpress-mobile/gutenberg-mobile#1866 Enable Button block in production
wordpress-mobile/gutenberg-mobile#1855 Enable gallery upload options in production
wordpress-mobile/gutenberg-mobile#1837 Correct layout within bottom-sheet
wordpress-mobile/gutenberg-mobile#1834 Replace Slider with Stepper for columns settings on Gallery block
wordpress-mobile/gutenberg-mobile#1859 Feat: refine block borders
wordpress-mobile/gutenberg-mobile#1872 Fix layout issue in Shortcode
wordpress-mobile/gutenberg-mobile#1850 Feat: Open Group block for production
wordpress-mobile/gutenberg-mobile#1838 Adjust vertical margins in InnerBlock
wordpress-mobile/gutenberg-mobile#1798 Fix gallery size labels
Changes - After the Release Branch was Cut
wordpress-mobile/gutenberg-mobile#1894 Fix inserter
wordpress-mobile/gutenberg-mobile#1930 Make sure strong tags are removed from title
wordpress-mobile/gutenberg-mobile#1938 Fix alignment issues
To Test
Smoke test the app and report if all OK
Please try the items in the changelog above and report the test outcome of each one that you tested
PR submission checklist:
RELEASE-NOTES.txtif necessary.