Skip to content

Removing DEV flag for Image block size options#1904

Merged
cameronvoell merged 3 commits intodevelopfrom
add/image-size-options-without-dev-flag
Feb 14, 2020
Merged

Removing DEV flag for Image block size options#1904
cameronvoell merged 3 commits intodevelopfrom
add/image-size-options-without-dev-flag

Conversation

@cameronvoell
Copy link
Copy Markdown
Contributor

@cameronvoell cameronvoell commented Feb 14, 2020 •
edited
Loading

Fixes #1329

Description

We recently finished resolving behavioral issues related to updating images sizes on mobile, and are therefore removing the DEV flag blocking the feature in non-development builds.
See - #1593

Related PRs:

Screenshot

size-changes

To test

(Changes tested in individual PRs from #1593):
(Must be tested in WP Apps, see test PRs above)

  1. Add an Image Block and upload an image
  2. Click the gear for block settings
  3. Tap Image Size row and verify value cycles through available sizes (Thumbnail, Medium, Large, Fullscreen).
  4. Verify the Image size changes as you click through the menu.
  5. Verify the Image Size is preserved if you update the post, leave, and return.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

This was referenced Feb 14, 2020
Closed
Merged
Closed
Closed
@cameronvoell cameronvoell added this to the 1.23 milestone Feb 14, 2020
@cameronvoell cameronvoell added Media Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile labels Feb 14, 2020
@cameronvoell cameronvoell marked this pull request as ready for review February 14, 2020 07:49
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Feb 14, 2020

Thank you @cameronvoell for this!
Changes look good, but I'm investigating the failing tests on wordpress-mobile/WordPress-iOS#13462

It doesn't seem to be related to this particular PR, but I'd be more confident to merge after this is figured out.

etoledom
etoledom approved these changes Feb 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the UI Tests failure on WPiOS will be fixed separately and has no relation with this PR.

Lets :shipit: ! 🎉
Thank you @cameronvoell 🙏

Let's also revert the bundles before merging this PR.

@cameronvoell cameronvoell force-pushed the add/image-size-options-without-dev-flag branch from 816a759 to 16b0bd1 Compare February 14, 2020 15:26
@cameronvoell
Copy link
Copy Markdown
Contributor Author

cameronvoell commented Feb 14, 2020

Bundle update reverted, and gutenberg reference updated., merging!

@cameronvoell cameronvoell merged commit 6ec05f0 into develop Feb 14, 2020
This was referenced Feb 17, 2020
Merged
Merged
Merged
@etoledom etoledom deleted the add/image-size-options-without-dev-flag branch February 24, 2020 08:58
@etoledom etoledom mentioned this pull request Feb 24, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ceyhun ceyhun Awaiting requested review from ceyhun

1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile Media

Projects

None yet

Milestone

1.23

Development

Successfully merging this pull request may close these issues.

Add Size options to Image Block

2 participants

@cameronvoell @etoledom