Skip to content

Update aztec to 1.16.0#1857

Merged
SergioEstevao merged 4 commits intodevelopfrom
update_aztec_to_1.16.0
Feb 17, 2020
Merged

Update aztec to 1.16.0#1857
SergioEstevao merged 4 commits intodevelopfrom
update_aztec_to_1.16.0

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Feb 5, 2020 •
edited
Loading

Updates Aztec to version 1.16.0

To test:

  • Start the demo app
  • Smoke test the demo content, especially the list block indents with ordered lists.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added this to the 1.22 milestone Feb 5, 2020
@SergioEstevao SergioEstevao changed the base branch from release/1.22.0 to develop February 6, 2020 10:40
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Feb 7, 2020 •
edited
Loading

@SergioEstevao - shouldn't this target the release branch? 🤔
cc @hypest

@SergioEstevao SergioEstevao modified the milestones: 1.22, 1.23 Feb 8, 2020
@SergioEstevao
Copy link
Copy Markdown
Contributor Author

SergioEstevao commented Feb 8, 2020

@etoledom, because this is not fixing any regression specific for this version we decided to merge to develop.

Can you review it after the 1.22.0 is merged on develop?

etoledom
etoledom approved these changes Feb 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergioEstevao - I have updated from develop and tested. Everything looks good!

Maybe we could add an entry to the release notes about fixing the layout of ordered lists with large numbers (Unless it's already listed on WPiOS)

@SergioEstevao SergioEstevao merged commit d8811f9 into develop Feb 17, 2020
@SergioEstevao SergioEstevao deleted the update_aztec_to_1.16.0 branch February 17, 2020 12:35
@mchowning
Copy link
Copy Markdown
Contributor

mchowning commented Feb 17, 2020

👋 @SergioEstevao and @etoledom ! Just wanted to sanity check that it is fine that react-native-aztec/ios/Cartfile still has a "1.15.0" version.

@SergioEstevao
Copy link
Copy Markdown
Contributor Author

SergioEstevao commented Feb 17, 2020 •
edited
Loading

Yep it's ok since we upgrade to RN 0.61.5 that file is completely ignored, what matters now is what is defined in RNTAztecView.podspec

@mchowning
Copy link
Copy Markdown
Contributor

mchowning commented Feb 17, 2020

since we upgrade to RN 0.61.5 that file is completely ignored

Could we delete it?

This was referenced Feb 17, 2020
Merged
Merged
@SergioEstevao
Copy link
Copy Markdown
Contributor Author

SergioEstevao commented Feb 18, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hypest hypest

@etoledom etoledom

Labels

None yet

Projects

None yet

Milestone

1.23

Development

Successfully merging this pull request may close these issues.

4 participants

@SergioEstevao @etoledom @mchowning @hypest