Conversation
This was referenced Jan 22, 2020
bdc663a to
106e02c
Compare
chipsnyder
approved these changes
Jan 23, 2020
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
Tested in Wordpress iOS and Wordpress Android working as expected
geriux
approved these changes
Jan 23, 2020
Contributor
geriux
left a comment
There was a problem hiding this comment.
Approved by WordPress/gutenberg#19800 (review)
2 tasks
This was referenced Feb 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1792
Related PR
gutenberg: WordPress/gutenberg#19800Description
This PR fixes the image size option labels in the gallery block settings. The image size options were added for web, but on mobile, the labels were undefined. This resulted in "blank" buttons, and in the beta build for iOS this also resulted in a crash.
How has this been tested?
Tested on Android via WordPress-Android, and iOS via WordPress-iOS:
Steps:
Expected result:
Steps:
Expected result:
The image resolution should change (to a lower quality with thumbnail, higher quality with large or full).
Screenshots
Types of changes
On mobile, the
nameproperty in imageSizes is undefined, butlabelis already set. So this PR defaults to using thelabelif it is truthy, and falls back to using thenameif not.PR submission checklist:
RELEASE-NOTES.txtif necessary.