Skip to content

Fix menu item width inside the inserter#1914

Merged
lukewalczak merged 6 commits intodevelopfrom
callstack/rnmobile/patch-bottom-sheet
Feb 17, 2020
Merged

Fix menu item width inside the inserter#1914
lukewalczak merged 6 commits intodevelopfrom
callstack/rnmobile/patch-bottom-sheet

Conversation

@lukewalczak
Copy link
Copy Markdown
Contributor

@lukewalczak lukewalczak commented Feb 14, 2020

Fixes #1906
Fixes #1907

Ref to gutenberg: WordPress/gutenberg#20238

To test:

  1. Change device font size to the largest
  2. Change display zoom to max (if available)
  3. Open the app
  4. Press the inserter
  5. Observe if all the items are displayed properly within a grid

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak requested a review from etoledom February 14, 2020 15:53
@lukewalczak
Copy link
Copy Markdown
Contributor Author

@bisko @etoledom Could you please check the latest changes?

Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block Add chooser: Buttons misaligned with longer translations Bad layout on bottom sheets with big text sizes

2 participants