Skip to content

Feat: Open Group block for production#1850

Merged
jbinda merged 6 commits intodevelopfrom
callstack/open-group-block
Feb 6, 2020
Merged

Feat: Open Group block for production#1850
jbinda merged 6 commits intodevelopfrom
callstack/open-group-block

Conversation

@jbinda
Copy link
Copy Markdown
Contributor

@jbinda jbinda commented Feb 3, 2020 •
edited
Loading

Fixes #1824

PR opens Group block for production..

Please also refer to:
Related gutenberg PR
Related gutenberg-mobile issue

WordPress iOS -> wordpress-mobile/WordPress-iOS#13367
WordPress Android -> wordpress-mobile/WordPress-Android#11231

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jbinda jbinda added [Type] Enhancement Improves a current area of the editor InnerBlocks labels Feb 3, 2020
@jbinda jbinda requested a review from pinarol February 3, 2020 13:14
@jbinda jbinda mentioned this pull request Feb 4, 2020
Merged
6 tasks
@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Feb 4, 2020 •
edited by jbinda
Loading

@jbinda hi 👋 Could you address below items in this PR?

  • Generate bundles and open WPiOS and WPAndroid PRs
    (This is necessary to be able to test this because we should test with metro off.)

  • Add release notes.

See similar PR: #1594

@pinarol pinarol requested review from chipsnyder and geriux and removed request for pinarol February 4, 2020 07:35
@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Feb 4, 2020

@chipsnyder @geriux After main APP PRs are created, could you please take one platform for yourself and test the Group block? I recommend using the peril links main app PR will give us and directly installing the apps in real device.

Recommended test steps can be found here but no need to limit yourselves with those. Thanks!

@jbinda jbinda force-pushed the callstack/open-group-block branch from fb4a5c6 to 720e8f9 Compare February 4, 2020 14:08
@geriux
Copy link
Copy Markdown
Contributor

geriux commented Feb 5, 2020

Hey @chipsnyder 👋 I'll check it out on iOS 🍎

geriux
geriux approved these changes Feb 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@geriux geriux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the iOS side by WordPress/gutenberg#20004 (review)

chipsnyder
chipsnyder approved these changes Feb 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the Android side as well. Looks good 👍 WordPress/gutenberg#20004 (review)

@jbinda jbinda requested a review from pinarol February 6, 2020 10:00
@jbinda jbinda merged commit e40988d into develop Feb 6, 2020
@jbinda
Copy link
Copy Markdown
Contributor Author

jbinda commented Feb 6, 2020

merged ! 🎉

@jbinda jbinda self-assigned this Feb 6, 2020
This was referenced Feb 17, 2020
Merged
Merged
Merged
@jbinda jbinda deleted the callstack/open-group-block branch March 12, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinarol pinarol Awaiting requested review from pinarol

2 more reviewers

@chipsnyder chipsnyder chipsnyder approved these changes

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jbinda jbinda

Labels

InnerBlocks [Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Open Group block for production

4 participants

@jbinda @pinarol @geriux @chipsnyder