Skip to content

[RNMobile] Remove devOnly flag from Group block#20004

Merged
jbinda merged 2 commits intomasterfrom
rnmobile/open-group-block
Feb 6, 2020
Merged

[RNMobile] Remove devOnly flag from Group block#20004
jbinda merged 2 commits intomasterfrom
rnmobile/open-group-block

Conversation

@jbinda
Copy link
Copy Markdown
Contributor

@jbinda jbinda commented Feb 3, 2020 •
edited
Loading

Description

Open Group Block for production by removing devOnly flag according to this ticket

Please also refer to:
Related gutenberg-mobile PR

How has this been tested?

WordPress iOS -> wordpress-mobile/WordPress-iOS#13367
WordPress Android -> wordpress-mobile/WordPress-Android#11231

Types of changes

New feature (Group block)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@jbinda jbinda added [Feature] Blocks Overall functionality of blocks [Block] Group Affects the Group Block (and row, stack and grid variants) labels Feb 3, 2020
@jbinda jbinda requested review from lukewalczak and pinarol February 3, 2020 13:11
@jbinda jbinda mentioned this pull request Feb 3, 2020
Merged
2 tasks
@pinarol pinarol removed their request for review February 4, 2020 07:27
@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Feb 4, 2020

@jbinda Related gutenberg-mobile PR link in the description seems to point this PR again, could you fix that?

@jbinda
Copy link
Copy Markdown
Contributor Author

jbinda commented Feb 4, 2020

Sure, done.

@jbinda jbinda mentioned this pull request Feb 4, 2020
Closed
3 tasks
@jbinda jbinda requested a review from pinarol February 4, 2020 13:42
@pinarol pinarol requested review from geriux and removed request for lukewalczak and pinarol February 4, 2020 13:50
@jbinda jbinda mentioned this pull request Feb 4, 2020
Closed
3 tasks
geriux
geriux approved these changes Feb 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@geriux geriux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great on wordpress-mobile/WordPress-iOS#13367 👏

Amazing work! I did some inception tests nesting different blocks and groups within groups and it didn't break 😏🙌 (besides the other suggested test cases that all worked flawlessly too)

Tested only on iOS

Pending Android

@jbinda
Copy link
Copy Markdown
Contributor Author

jbinda commented Feb 5, 2020

@geriux Thanks for testing and feedback !

chipsnyder
chipsnyder approved these changes Feb 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on Android as well wordpress-mobile/WordPress-Android#11231 🚀

@jbinda
Copy link
Copy Markdown
Contributor Author

jbinda commented Feb 6, 2020

Once again thanks for testing, merged ! 🚀

@jbinda jbinda merged commit 3233362 into master Feb 6, 2020
@jbinda jbinda deleted the rnmobile/open-group-block branch February 6, 2020 09:19
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 6, 2020
@jbinda jbinda self-assigned this Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chipsnyder chipsnyder chipsnyder approved these changes

+1 more reviewer

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jbinda jbinda

Labels

[Block] Group Affects the Group Block (and row, stack and grid variants) [Feature] Blocks Overall functionality of blocks

Projects

None yet

Milestone

Gutenberg 7.5

Development

Successfully merging this pull request may close these issues.

4 participants

@jbinda @pinarol @chipsnyder @geriux