Skip to content

Fix title with emojis#1930

Merged
mchowning merged 4 commits intorelease/1.23.0from
issue/1929_emoji_on_title
Feb 18, 2020
Merged

Fix title with emojis#1930
mchowning merged 4 commits intorelease/1.23.0from
issue/1929_emoji_on_title

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Feb 18, 2020

Fixes #1929 and #1613

GB PR: WordPress/gutenberg#20288

To test:

  • Open the demo app
  • Add emoji to the title of the post for example: 🌈Testing!🌈
  • Switch to HTML mode
  • Check that no extra strong element are added to the title.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the [Type] Bug Something isn't working label Feb 18, 2020
@SergioEstevao SergioEstevao added this to the 1.23 milestone Feb 18, 2020
@SergioEstevao SergioEstevao mentioned this pull request Feb 18, 2020
Closed
6 tasks
@SergioEstevao SergioEstevao mentioned this pull request Feb 18, 2020
Merged
6 tasks
mchowning
mchowning approved these changes Feb 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mchowning mchowning left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#20291

This was referenced Feb 18, 2020
Merged
Merged
Merged
@mchowning mchowning merged commit 7b01871 into release/1.23.0 Feb 18, 2020
@mchowning mchowning deleted the issue/1929_emoji_on_title branch February 18, 2020 20:55
mchowning added a commit to wordpress-mobile/WordPress-Android that referenced this pull request Feb 18, 2020
@mchowning
Update release notes
12fbfd0 
For fix in wordpress-mobile/gutenberg-mobile#1930
@SergioEstevao SergioEstevao changed the title Update GB reference. Fix title with emojis Feb 19, 2020
mchowning added a commit to wordpress-mobile/WordPress-iOS that referenced this pull request Feb 19, 2020
@mchowning
Update release notes
683405d 
For fix in
wordpress-mobile/gutenberg-mobile#1930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etoledom etoledom Awaiting requested review from etoledom

1 more reviewer

@mchowning mchowning mchowning approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Bug Something isn't working

Projects

None yet

Milestone

1.23

Development

Successfully merging this pull request may close these issues.

2 participants

@SergioEstevao @mchowning