Make sure that all strong tags are removed from title.#20291
Merged
Make sure that all strong tags are removed from title.#20291
Conversation
6 tasks
mchowning
approved these changes
Feb 18, 2020
Contributor
mchowning
left a comment
There was a problem hiding this comment.
Tested and works great! 👍
mchowning
pushed a commit
that referenced
this pull request
Feb 18, 2020
mchowning
added a commit
that referenced
this pull request
Feb 22, 2020
* Add view with accesibility label on top of floating toolbar (#20267) * [FIX] inserter point in mobile app (#20195) * fix inserter point in gutenberg-mobile * Make sure that all strong tags are removed from title. (#20291) Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com> Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change makes sure that any extra
strongelement tags added on the post-title are removed correctly. This could have happened because of the presence of emoji characters on the title that made the RichText native element to add extrastrongelements around the emojis.How has this been tested?
This can be tested with this GB-mobile PR: wordpress-mobile/gutenberg-mobile#1930
Screenshots
Types of changes
Bug fix
Checklist: