Skip to content

Enable gallery upload options in production#1855

Merged
mkevins merged 11 commits intodevelopfrom
feature/gallery-upload-options
Feb 13, 2020
Merged

Enable gallery upload options in production#1855
mkevins merged 11 commits intodevelopfrom
feature/gallery-upload-options

Conversation

@mkevins
Copy link
Copy Markdown
Contributor

@mkevins mkevins commented Feb 5, 2020 •
edited
Loading

Fixes #1610

Sibling PRs

Description

This PR enables gallery block upload options in production (on mobile).

Reviewing

Generating bundles results in a large diff due to this recent change. The relevant diff for this PR is here and also the gutenberg reference update.

To test: #1610 (comment)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mkevins mkevins added [Type] Enhancement Improves a current area of the editor Media labels Feb 5, 2020
This was referenced Feb 5, 2020
Merged
Closed
Merged
chipsnyder
chipsnyder reviewed Feb 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subfolders in bundle/android/* and bundle/ios/* Where previously added and then removed again in here

Sorry if this is a basic question, what's the reason for re-adding them here?

@mkevins
Copy link
Copy Markdown
Contributor Author

mkevins commented Feb 10, 2020

Hi @chipsnyder 👋

The subfolders in bundle/android/* and bundle/ios/* Where previously added and then removed again in here

Sorry if this is a basic question, what's the reason for re-adding them here?

There are a couple things going on here, I'll try to clarify:

The removal you mention is part of #1844 to revert commits accidentally pushed directly to develop.

The bundles added here are only for the purpose of generating WordPress-Android and WordPress-iOS builds on CI, and can be reverted before this PR is merged.

Let me know if this helps.

@chipsnyder
Copy link
Copy Markdown
Contributor

chipsnyder commented Feb 10, 2020

Yup, that clears it up! Thanks @mkevins

@mkevins mkevins marked this pull request as ready for review February 11, 2020 08:04
chipsnyder
chipsnyder approved these changes Feb 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved with #1610 (comment)

geriux
geriux approved these changes Feb 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved by WordPress/gutenberg#20043 (review)

@mkevins mkevins merged commit 6352c21 into develop Feb 13, 2020
@mkevins mkevins deleted the feature/gallery-upload-options branch February 13, 2020 03:19
@mkevins mkevins mentioned this pull request Feb 13, 2020
Open
14 tasks
This was referenced Feb 17, 2020
Merged
Merged
@mchowning mchowning mentioned this pull request Feb 17, 2020
Merged
3 tasks
@chipsnyder chipsnyder mentioned this pull request Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamthomasbishop iamthomasbishop Awaiting requested review from iamthomasbishop

2 more reviewers

@chipsnyder chipsnyder chipsnyder approved these changes

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Media [Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mobile gallery block - Upload options

3 participants

@mkevins @chipsnyder @geriux