Skip to content

Enable gallery upload options in production#11234

Closed
mkevins wants to merge 5 commits intodevelopfrom
feature/gallery-upload-options
Closed

Enable gallery upload options in production#11234
mkevins wants to merge 5 commits intodevelopfrom
feature/gallery-upload-options

Conversation

@mkevins
Copy link
Copy Markdown
Contributor

@mkevins mkevins commented Feb 5, 2020

Sibling PRs

Description

This PR enables gallery block upload options in production (on mobile).

To test: wordpress-mobile/gutenberg-mobile#1610 (comment)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 5, 2020

You can test the changes on this Pull Request by downloading the APK here.

@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Feb 6, 2020

cc @iamthomasbishop Gallery upload options are ready for testing
test cases and list of known issues are here

Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the cases here and it worked great! Great work :)
wordpress-mobile/gutenberg-mobile#1610 (comment)

@mkevins
Copy link
Copy Markdown
Contributor Author

mkevins commented Feb 13, 2020

Closing as this PR was for testing purposing only (wordpress-mobile/gutenberg-mobile#1855 has been merged).

@mkevins mkevins closed this Feb 13, 2020
@mkevins mkevins deleted the feature/gallery-upload-options branch February 13, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants