Skip to content

Enable gallery upload options in production#13374

Merged
mkevins merged 8 commits intodevelopfrom
feature/gallery-upload-options
Feb 13, 2020
Merged

Enable gallery upload options in production#13374
mkevins merged 8 commits intodevelopfrom
feature/gallery-upload-options

Conversation

@mkevins
Copy link
Copy Markdown
Contributor

@mkevins mkevins commented Feb 5, 2020

Sibling PRs

Description

This PR enables gallery block upload options in production (on mobile).

To test: wordpress-mobile/gutenberg-mobile#1610 (comment)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mkevins mkevins added [Type] Enhancement Media Gutenberg Editing and display of Gutenberg blocks. labels Feb 5, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 5, 2020

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 5, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Feb 6, 2020

cc @iamthomasbishop Gallery upload options are ready for testing
test cases and list of known issues are here

@mkevins mkevins marked this pull request as ready for review February 12, 2020 08:59
Copy link
Copy Markdown
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkevins mkevins merged commit 0a3bffb into develop Feb 13, 2020
@mkevins mkevins deleted the feature/gallery-upload-options branch February 13, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks. Media

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants