[Gutenberg] Support Multiple uploads in Gallery#13404
Merged
chipsnyder merged 2 commits intofeature/gallery-upload-optionsfrom Feb 10, 2020
Merged
[Gutenberg] Support Multiple uploads in Gallery#13404chipsnyder merged 2 commits intofeature/gallery-upload-optionsfrom
chipsnyder merged 2 commits intofeature/gallery-upload-optionsfrom
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
mkevins
approved these changes
Feb 10, 2020
Contributor
mkevins
left a comment
There was a problem hiding this comment.
Tested via Image, Media & Text, and Gallery blocks: everything works as expected. Nice work @chipsnyder 🎉
LGTM!
| insertOnBlock(with: [firstItem]) | ||
| } | ||
| // Append the rest of images via `.appendMedia` event. | ||
| // Ideally we would send all picked images via the given callback, but that seems to not be possible yet. |
Contributor
There was a problem hiding this comment.
np: although not part of the changeset, should this comment be updated (i.e. does this PR make this possible now)?
Contributor
Author
There was a problem hiding this comment.
Good question! When I tested it out by forcing the Image Block down the multiple upload path with all of the images, it would only upload the first image and drop the rest. With the Gallery Block enabled now, it might be worth revisiting how to handle this case.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#1863
To Test:
Gallary Block:
Expect: All images should be added to the Gallery Block in the selected order
Image Block:
Expect: All images should be added as separate Image Blocks
Media & Text:
Expect: The first image should be added to the Media block and the rest of the images should be added as separate Image Blocks
PR submission checklist:
RELEASE-NOTES.txtif necessary.