[quant][graphmode] quantization support for aten::rehshape#34803
Closed
jerryzh168 wants to merge 7 commits intogh/jerryzh168/249/basefrom
Closed
[quant][graphmode] quantization support for aten::rehshape#34803jerryzh168 wants to merge 7 commits intogh/jerryzh168/249/basefrom
jerryzh168 wants to merge 7 commits intogh/jerryzh168/249/basefrom
Conversation
Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 16, 2020
Closed
Closed
💊 CircleCI build failures summary and remediationsAs of commit 7488d10 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 31 times. |
Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 17, 2020
Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
supriyar
reviewed
Mar 17, 2020
Contributor
supriyar
left a comment
There was a problem hiding this comment.
The test added just seems to check if dequantize will be swapped. Don't we need a test to check reshape op standalone?
Contributor
Author
|
@supriyar making sure the dequantize will be swapped after reshape is how we quantize it. |
Contributor
Author
|
For context, please see: 776d2a1#diff-1aea24a8684a93a8be65d804f891ee85 |
supriyar
approved these changes
Mar 18, 2020
Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504457](https://our.internmc.facebook.com/intern/diff/D20504457) [ghstack-poisoned]
Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20504457](https://our.internmc.facebook.com/intern/diff/D20504457) [ghstack-poisoned]
Contributor
|
This pull request has been merged in b2e5e0c. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…4803) Summary: Pull Request resolved: pytorch#34803 Test Plan: python test/test_jit.py Imported from OSS Differential Revision: D20504457 fbshipit-source-id: 5ca691ef4880c72d30d62390e63e3288b2f06dce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
python test/test_jit.py
Reviewers:
.
Subscribers:
Tasks:
Tags:
Differential Revision: D20504457