[quant][graphmode][refactor] insertObservers for Block#34414
Closed
jerryzh168 wants to merge 28 commits intogh/jerryzh168/243/basefrom
Closed
[quant][graphmode][refactor] insertObservers for Block#34414jerryzh168 wants to merge 28 commits intogh/jerryzh168/243/basefrom
jerryzh168 wants to merge 28 commits intogh/jerryzh168/243/basefrom
Conversation
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 7, 2020
This was referenced Mar 7, 2020
Closed
Closed
💊 CircleCI build failures summary and remediationsAs of commit 68dac23 (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
🚧 2 upstream failures:These were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 131 times. |
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 10, 2020
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 11, 2020
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
This was referenced Mar 19, 2020
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
This was referenced Mar 21, 2020
Closed
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20519604](https://our.internmc.facebook.com/intern/diff/D20519604) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 350c522. |
okly366
pushed a commit
to okly366/pytorch
that referenced
this pull request
Apr 26, 2020
Summary: Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Reviewers: . Subscribers: Tasks: Tags: ghstack-source-id: 4d00783 Pull Request resolved: pytorch/pytorch#34414
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#34414 Previously we insert observers for Graph(graph is a wrapper around a Block), this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks. Test Plan: . Imported from OSS Differential Revision: D20519604 fbshipit-source-id: 1908913ea7f0898cd7b4f2edd1f81cdfedf8a211
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Previously we insert observers for Graph(graph is a wrapper around a Block),
this PR added insertObservers for Block, so that the code can work for the nodes that have sub blocks.
Test Plan:
.
Reviewers:
.
Subscribers:
Tasks:
Tags:
Differential Revision: D20519604