Skip to content

[quant][graphmode] Add quantization support for aten::cat#34346

Closed
jerryzh168 wants to merge 25 commits intogh/jerryzh168/238/basefrom
gh/jerryzh168/238/head
Closed

[quant][graphmode] Add quantization support for aten::cat#34346
jerryzh168 wants to merge 25 commits intogh/jerryzh168/238/basefrom
gh/jerryzh168/238/head

Conversation

@jerryzh168
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 commented Mar 6, 2020 •
edited
Loading

Stack from ghstack:

Summary:

Test Plan:
python test/test_jit.py

Reviewers:
.

Subscribers:

Tasks:

Tags:

Differential Revision: D20589145

@jerryzh168 jerryzh168 requested a review from apaszke as a code owner March 6, 2020 02:32
This was referenced Mar 6, 2020
Closed
Closed
Closed
Closed
Closed
Closed
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 6, 2020
This was referenced Mar 6, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 6, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 8a8fc28 (more details on the Dr. CI page):

✅ None of the build failures appear to be your fault 💚

  • 2/3 tentatively recognized as flaky ❄️

  • 1/3 broken upstream at merge base 618c621 from Mar 23 until Mar 24 (47 commits; 77ccb5c - 3f896ef)

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

    Check out the recency history of this "viable master" tracking branch.

❄️ 2 tentatively flaky failures

2 failures tentatively classified as flaky but have not triggered reruns to confirm:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/2)

Step: "Test" (full log | pattern match details) ❄️

Mar 24 19:31:46 AssertionError: 12 not less than or equal to 1e-05 : 
Mar 24 19:31:46 ---------------------------------------------------------------------- 
Mar 24 19:31:46 Traceback (most recent call last): 
Mar 24 19:31:46   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 24 19:31:46     self._join_processes(fn) 
Mar 24 19:31:46   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 24 19:31:46     self._check_return_codes(elapsed_time) 
Mar 24 19:31:46   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 324, in _check_return_codes 
Mar 24 19:31:46     self.assertEqual(p.exitcode, first_process.exitcode) 
Mar 24 19:31:46   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 24 19:31:46     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 24 19:31:46 AssertionError: 12 not less than or equal to 1e-05 :  
Mar 24 19:31:46  
Mar 24 19:31:46 ---------------------------------------------------------------------- 
Mar 24 19:31:46 Ran 29 tests in 95.979s 
Mar 24 19:31:46  
Mar 24 19:31:46 FAILED (failures=1) 
Mar 24 19:31:46  
Mar 24 19:31:46 Generating XML reports... 
Mar 24 19:31:46 Generated XML report: test-reports/dist-gloo/TEST-JitRpcTestWithSpawn-20200324193010.xml 
Mar 24 19:31:46 Traceback (most recent call last): 
Mar 24 19:31:46   File "test/run_test.py", line 682, in <module>

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (2/2)

Step: "Test" (full log | pattern match details) ❄️

Mar 24 21:11:04 AssertionError: 11 not less than or equal to 1e-05 : 
Mar 24 21:11:04 ---------------------------------------------------------------------- 
Mar 24 21:11:04 Traceback (most recent call last): 
Mar 24 21:11:04   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 24 21:11:04     self._join_processes(fn) 
Mar 24 21:11:04   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 24 21:11:04     self._check_return_codes(elapsed_time) 
Mar 24 21:11:04   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 328, in _check_return_codes 
Mar 24 21:11:04     self.assertEqual(first_process.exitcode, 0) 
Mar 24 21:11:04   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 24 21:11:04     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 24 21:11:04 AssertionError: 11 not less than or equal to 1e-05 :  
Mar 24 21:11:04  
Mar 24 21:11:04 ---------------------------------------------------------------------- 
Mar 24 21:11:04 Ran 29 tests in 23.039s 
Mar 24 21:11:04  
Mar 24 21:11:04 FAILED (failures=1) 
Mar 24 21:11:04  
Mar 24 21:11:04 Generating XML reports... 
Mar 24 21:11:04 Generated XML report: test-reports/dist-gloo/TEST-JitRpcTestWithSpawn-20200324211041.xml 
Mar 24 21:11:04 Traceback (most recent call last): 
Mar 24 21:11:04   File "test/run_test.py", line 682, in <module>
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 162 times.

This was referenced Mar 7, 2020
Closed
Closed
raghuramank100
raghuramank100 reviewed Mar 9, 2020
View reviewed changes
Comment thread torch/csrc/jit/passes/quantization_patterns.h
This was referenced Mar 10, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::cat"
2ad0bd1 
Summary:

Test Plan:
python test/test_jit.py

Reviewers:
.

Subscribers:

Tasks:

Tags:

Differential Revision: [D20589145](https://our.internmc.facebook.com/intern/diff/D20589145)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::cat"
61f255b 
Summary:

Test Plan:
python test/test_jit.py

Reviewers:
.

Subscribers:

Tasks:

Tags:

Differential Revision: [D20589145](https://our.internmc.facebook.com/intern/diff/D20589145)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::cat"
bdeb114 
Summary:

Test Plan:
python test/test_jit.py

Reviewers:
.

Subscribers:

Tasks:

Tags:

Differential Revision: [D20589145](https://our.internmc.facebook.com/intern/diff/D20589145)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Mar 24, 2020
@jerryzh168 @facebook-github-bot
[quant][graphmode] Add prim::ListConstruct to general op handling (#3…
cd75d4e 
…4345)

Summary:
Pull Request resolved: #34345

prim::ListConstruct is similar to an op that doesn't require observation
we want to make sure we can propagate observed property through it

Test Plan:
this will be tested when we add support for cat
#34346

Imported from OSS

Differential Revision: D20524455

fbshipit-source-id: b5f8e0c8776d48d588aeba6735de06dcd308560e
@jerryzh168
Update on "[quant][graphmode] Add quantization support for aten::cat"
8a8fc28 
Summary:

Test Plan:
python test/test_jit.py

Reviewers:
.

Subscribers:

Tasks:

Tags:

Differential Revision: [D20589145](https://our.internmc.facebook.com/intern/diff/D20589145)

[ghstack-poisoned]
@albanD
Copy link
Copy Markdown
Collaborator

albanD commented Mar 24, 2020 •
edited
Loading

Reverting this as the newly introduced test is failing on master for macos and windows builds: https://app.circleci.com/pipelines/github/pytorch/pytorch/145635/workflows/e811c5de-9af3-4709-9f98-8b88e515b4e5/jobs/4934900

This was referenced Mar 24, 2020
Closed
Closed
Closed
Closed
Closed
jerryzh168 added a commit that referenced this pull request Mar 24, 2020
@jerryzh168
[reland][quant][graphmode] Add quantization support for aten::cat (#3…
e5e6ea2 
…4346)

Summary:

Test Plan:
python test/test_jit.py

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Mar 24, 2020
Closed
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 24, 2020

This pull request has been merged in 6b5740c.

This was referenced Mar 25, 2020
Closed
Closed
Closed
jerryzh168 added a commit that referenced this pull request Mar 25, 2020
@jerryzh168
Update on "[reland][quant][graphmode] Add quantization support for at…
19d2b63 
…en::cat (#34346)"

Summary:

Test Plan:
python test/test_jit.py

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Mar 25, 2020
@jerryzh168 @facebook-github-bot
[reland][quant][graphmode] Add quantization support for aten::cat (#3…
15e5453 
…4346) (#35337)

Summary: Pull Request resolved: #35337

Test Plan: python test/test_jit.py

Differential Revision: D20648201

Pulled By: jerryzh168

fbshipit-source-id: f6570c3ee2f48a9bc6373d2af873824ac2c8ef62
@jerryzh168 jerryzh168 mentioned this pull request Mar 25, 2020
Closed
jerryzh168 added a commit that referenced this pull request Mar 25, 2020
@jerryzh168
Update on "[reland][quant][graphmode] Add quantization support for at…
4330122 
…en::cat (#34346)"

Summary:

Test Plan:
python test/test_jit.py

Differential Revision: [D20648201](https://our.internmc.facebook.com/intern/diff/D20648201)

[ghstack-poisoned]
okly366 pushed a commit to okly366/pytorch that referenced this pull request Apr 26, 2020
@jerryzh168
[quant][graphmode] Add quantization support for aten::cat
2b2bfb4 
Summary:

Test Plan:
python test/test_jit.py

Reviewers:
.

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6268845
Pull Request resolved: pytorch/pytorch#34346
karansachdev-1012 pushed a commit to karansachdev-1012/pytorch that referenced this pull request Feb 17, 2026
@jerryzh168
[reland][quant][graphmode] Add quantization support for aten::cat (#3…
27a64aa 
…4346)

Summary: Pull Request resolved: pytorch/pytorch#34346

Test Plan:
python test/test_jit.py
ghstack-source-id: e2f48a5
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@jerryzh168 @facebook-github-bot
[quant][graphmode] Add prim::ListConstruct to general op handling (py…
b750216 
…torch#34345)

Summary:
Pull Request resolved: pytorch#34345

prim::ListConstruct is similar to an op that doesn't require observation
we want to make sure we can propagate observed property through it

Test Plan:
this will be tested when we add support for cat
pytorch#34346

Imported from OSS

Differential Revision: D20524455

fbshipit-source-id: b5f8e0c8776d48d588aeba6735de06dcd308560e
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@jerryzh168 @facebook-github-bot
[quant][graphmode] Add quantization support for aten::cat (pytorch#34346
95dcbe1 
)

Summary: Pull Request resolved: pytorch#34346

Test Plan:
python test/test_jit.py

Imported from OSS

Differential Revision: D20589145

fbshipit-source-id: c9159fffa88cf25fcdccfcc4eef2622cf4b250b5
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@jerryzh168 @facebook-github-bot
[reland][quant][graphmode] Add quantization support for aten::cat (py…
b733b6e 
…torch#34346) (pytorch#35337)

Summary: Pull Request resolved: pytorch#35337

Test Plan: python test/test_jit.py

Differential Revision: D20648201

Pulled By: jerryzh168

fbshipit-source-id: f6570c3ee2f48a9bc6373d2af873824ac2c8ef62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supriyar supriyar supriyar approved these changes

@apaszke apaszke Awaiting requested review from apaszke

+1 more reviewer

@raghuramank100 raghuramank100 raghuramank100 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jerryzh168 @albanD @facebook-github-bot @supriyar @raghuramank100 @mruberry