[quant][graphmode] Make interpolate/upsample work again#35130
Closed
jerryzh168 wants to merge 22 commits intogh/jerryzh168/259/basefrom
Closed
[quant][graphmode] Make interpolate/upsample work again#35130jerryzh168 wants to merge 22 commits intogh/jerryzh168/259/basefrom
jerryzh168 wants to merge 22 commits intogh/jerryzh168/259/basefrom
Conversation
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 20, 2020
Closed
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CircleCI build failures summary and remediationsAs of commit 57dbb19 (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
🚧 1 upstream failure:These were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 103 times. |
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 21, 2020
Closed
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655303](https://our.internmc.facebook.com/intern/diff/D20655303) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 25, 2020
Summary: supporting swap dequant for prim::If nodes, this includes detecting all blocks of prim::If ends with dequantize, deleting these dequantize and inserting new dequantize for the output of prim::If Test Plan: see next PR that enables swap dequant for interpolate: #35130 Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655307](https://our.internmc.facebook.com/intern/diff/D20655307) [ghstack-poisoned]
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655303](https://our.internmc.facebook.com/intern/diff/D20655303) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 26, 2020
Summary: supporting swap dequant for prim::If nodes, this includes detecting all blocks of prim::If ends with dequantize, deleting these dequantize and inserting new dequantize for the output of prim::If Test Plan: see next PR that enables swap dequant for interpolate: #35130 Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655307](https://our.internmc.facebook.com/intern/diff/D20655307) [ghstack-poisoned]
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655303](https://our.internmc.facebook.com/intern/diff/D20655303) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 27, 2020
Summary: supporting swap dequant for prim::If nodes, this includes detecting all blocks of prim::If ends with dequantize, deleting these dequantize and inserting new dequantize for the output of prim::If Test Plan: see next PR that enables swap dequant for interpolate: #35130 Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655307](https://our.internmc.facebook.com/intern/diff/D20655307) [ghstack-poisoned]
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655303](https://our.internmc.facebook.com/intern/diff/D20655303) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 27, 2020
Summary: supporting swap dequant for prim::If nodes, this includes detecting all blocks of prim::If ends with dequantize, deleting these dequantize and inserting new dequantize for the output of prim::If Test Plan: see next PR that enables swap dequant for interpolate: #35130 Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655307](https://our.internmc.facebook.com/intern/diff/D20655307) [ghstack-poisoned]
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655303](https://our.internmc.facebook.com/intern/diff/D20655303) [ghstack-poisoned]
This was referenced Mar 27, 2020
jerryzh168
added a commit
that referenced
this pull request
Mar 27, 2020
Summary: supporting swap dequant for prim::If nodes, this includes detecting all blocks of prim::If ends with dequantize, deleting these dequantize and inserting new dequantize for the output of prim::If Test Plan: see next PR that enables swap dequant for interpolate: #35130 Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655307](https://our.internmc.facebook.com/intern/diff/D20655307) [ghstack-poisoned]
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655303](https://our.internmc.facebook.com/intern/diff/D20655303) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 27, 2020
Summary: supporting swap dequant for prim::If nodes, this includes detecting all blocks of prim::If ends with dequantize, deleting these dequantize and inserting new dequantize for the output of prim::If Test Plan: see next PR that enables swap dequant for interpolate: #35130 Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655307](https://our.internmc.facebook.com/intern/diff/D20655307) [ghstack-poisoned]
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655303](https://our.internmc.facebook.com/intern/diff/D20655303) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 27, 2020
Summary: supporting swap dequant for prim::If nodes, this includes detecting all blocks of prim::If ends with dequantize, deleting these dequantize and inserting new dequantize for the output of prim::If Test Plan: see next PR that enables swap dequant for interpolate: #35130 Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655307](https://our.internmc.facebook.com/intern/diff/D20655307) [ghstack-poisoned]
Summary: Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655303](https://our.internmc.facebook.com/intern/diff/D20655303) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 27, 2020
Summary: supporting swap dequant for prim::If nodes, this includes detecting all blocks of prim::If ends with dequantize, deleting these dequantize and inserting new dequantize for the output of prim::If Test Plan: see next PR that enables swap dequant for interpolate: #35130 Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20655307](https://our.internmc.facebook.com/intern/diff/D20655307) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2020
Summary: Pull Request resolved: #35142 supporting swap dequant for prim::If nodes, this includes detecting all blocks of prim::If ends with dequantize, deleting these dequantize and inserting new dequantize for the output of prim::If Test Plan: see next PR that enables swap dequant for interpolate: #35130 Imported from OSS Differential Revision: D20655307 fbshipit-source-id: 4fd53fbde8e169b7d98251e72ca37a29acdeb295
Contributor
|
This pull request has been merged in df27b32. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#35142 supporting swap dequant for prim::If nodes, this includes detecting all blocks of prim::If ends with dequantize, deleting these dequantize and inserting new dequantize for the output of prim::If Test Plan: see next PR that enables swap dequant for interpolate: pytorch#35130 Imported from OSS Differential Revision: D20655307 fbshipit-source-id: 4fd53fbde8e169b7d98251e72ca37a29acdeb295
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#35130 Test Plan: python test/test_jit.py TestJit.test_swap_dequantize_all_ops Imported from OSS Differential Revision: D20655303 fbshipit-source-id: 5ad8c6de28bcabffdfab4c9bc6a61f19f1d061cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
quantized::add_scalar_reluandquantized::add_scalar_relu_out#35509 [quant][graphmode] Quantization support forquantized::add_scalar_reluandquantized::add_scalar_relu_outaten::conv3d#35347 [quant][graphmode] Quantization support foraten::conv3dquantized::add#35345 [quant][graphmode][fix] Add filter forquantized::addaten::relua general op #35420 [quant][graphmode] Makeaten::relua general opprepare_scripttakes original qconfig_dict #35335 [quant][graphmode]prepare_scripttakes original qconfig_dictquantized::add_scalar#35334 [quant][graphmode] Quantization support forquantized::add_scalarSummary:
Test Plan:
python test/test_jit.py TestJit.test_swap_dequantize_all_ops
Reviewers:
.
Subscribers:
Tasks:
Tags:
Differential Revision: D20655303