[quant][graphmode] Quantization support for `quantized::add_scalar_relu` and `quantized::add_scalar_relu_out` by jerryzh168 · Pull Request #35509 · pytorch/pytorch

jerryzh168 · 2020-03-26T23:57:14Z

Stack from ghstack:

[quant] Move quantization tests into test/quantization #35688 [quant] Move quantization tests into test/quantization
[quant][graphmode] Quantization support for at::sort #35571 [quant][graphmode] Quantization support for at::sort
[quant][graphmode][refactor] getGeneralTensorInputs(Node*) -> getPassThroughInputs(Value*) #35558 [quant][graphmode][refactor] getGeneralTensorInputs(Node*) -> getPassThroughInputs(Value*)
[quant][graphmode][fix] docs for InsertObservers #35557 [quant][graphmode][fix] docs for InsertObservers
[quant][graphmode] Quantization support for quantized::add_scalar_relu and quantized::add_scalar_relu_out #35509 [quant][graphmode] Quantization support for quantized::add_scalar_relu and quantized::add_scalar_relu_out

Summary:

Test Plan:
python test/test_jit.py

Reviewers:
.

Subscribers:

Tasks:

Tags:

Differential Revision: D20742138

…lu` and `quantized::add_scalar_relu_out` Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

…lu` and `quantized::add_scalar_relu_out` Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: ghstack-source-id: 4ae32a6 Pull Request resolved: #35509

dr-ci · 2020-03-27T00:08:01Z

💊 CircleCI build failures summary and remediations

As of commit a6b30a3 (more details on the Dr. CI page):

✅ None of the build failures appear to be your fault 💚

1/1 broken upstream at merge base 0eb26fb from Mar 27 until Mar 30 (53 commits; b9adbb5 - 35dbc6e)
Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:
```
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
```
If your commit is older than viable/strict:
```
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
```
Check out the recency history of this "viable master" tracking branch.

🚧 1 upstream failure:

These were probably caused by upstream breakages:

pytorch_linux_backward_compatibility_check_test from Mar 27 until Mar 30 (53 commits; b9adbb5 - 35dbc6e)

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 79 times.

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

…lu` and `quantized::add_scalar_relu_out` Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: ghstack-source-id: e057dbc Pull Request resolved: #35509

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

supriyar · 2020-03-30T18:47:33Z

+            m = convert_script(m, True)
+            FileCheck().check_not("aten::add") \
+                       .check_not("aten::add_") \
+                       .check_not("aten::relu") \


Should we also check for quantized::add , quantized::relu?

supriyar · 2020-03-30T18:48:49Z

       add_scalar_out,
       quantized_add_scalar_out,
       add_scalar_filter},
+      {"quantized::cat", cat, quantized_cat},


is this change related to this PR?

this is just moving around quantized cat

supriyar

looks good. small comments.

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20742138](https://our.internmc.facebook.com/intern/diff/D20742138) [ghstack-poisoned]

facebook-github-bot · 2020-03-31T04:25:38Z

This pull request has been merged in 4e19e02.

…lu` and `quantized::add_scalar_relu_out` (pytorch#35509) Summary: Pull Request resolved: pytorch#35509 Test Plan: python test/test_jit.py Imported from OSS Differential Revision: D20742138 fbshipit-source-id: f6216d0af5da2bd5629aa4909f05dcde7853c8b8

[quant][graphmode] Quantization support for `quantized::add_scalar_re…

86dd193

…lu` and `quantized::add_scalar_relu_out` Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

jerryzh168 requested a review from apaszke as a code owner March 26, 2020 23:57

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 27, 2020

Update on "[quant][graphmode] Quantization support for `quantized::ad…

681e83b

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

jerryzh168 mentioned this pull request Mar 27, 2020

[fix] at::print for quantized Tensor #35545

Closed

Update on "[quant][graphmode] Quantization support for `quantized::ad…

e7fc9c8

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode] Quantization support for `quantized::ad…

50fdc27

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

This was referenced Mar 27, 2020

[quant][graphmode][fix] docs for InsertObservers #35557

Closed

[quant][graphmode][refactor] getGeneralTensorInputs(Node*) -> getPassThroughInputs(Value*) #35558

Closed

Update on "[quant][graphmode] Quantization support for `quantized::ad…

a3364e9

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

jerryzh168 mentioned this pull request Mar 27, 2020

[quant][graphmode] Quantization support for at::sort #35571

Closed

jerryzh168 added 7 commits March 27, 2020 14:16

Update on "[quant][graphmode] Quantization support for `quantized::ad…

d4fa279

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode] Quantization support for `quantized::ad…

61405f9

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode] Quantization support for `quantized::ad…

70b3c6f

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode] Quantization support for `quantized::ad…

ea54a43

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode] Quantization support for `quantized::ad…

07b3b9a

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode] Quantization support for `quantized::ad…

1d2ae6e

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode] Quantization support for `quantized::ad…

2e81ac6

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

jerryzh168 mentioned this pull request Mar 30, 2020

[quant] Move quantization tests into test/quantization #35688

Closed

Update on "[quant][graphmode] Quantization support for `quantized::ad…

77ff1f9

…d_scalar_relu` and `quantized::add_scalar_relu_out`" Summary: Test Plan: python test/test_jit.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]

supriyar reviewed Mar 30, 2020

View reviewed changes

supriyar approved these changes Mar 30, 2020

View reviewed changes

facebook-github-bot closed this in 4e19e02 Mar 30, 2020

facebook-github-bot added the merged label Mar 31, 2020

facebook-github-bot deleted the gh/jerryzh168/274/head branch April 3, 2020 14:18

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[quant][graphmode] Quantization support for `quantized::add_scalar_relu` and `quantized::add_scalar_relu_out`#35509

[quant][graphmode] Quantization support for `quantized::add_scalar_relu` and `quantized::add_scalar_relu_out`#35509
jerryzh168 wants to merge 14 commits intogh/jerryzh168/274/basefrom
gh/jerryzh168/274/head

jerryzh168 commented Mar 26, 2020 •

edited

Loading

Uh oh!

dr-ci Bot commented Mar 27, 2020 •

edited

Loading

Uh oh!

supriyar Mar 30, 2020

Uh oh!

supriyar Mar 30, 2020

Uh oh!

jerryzh168 Mar 30, 2020

Uh oh!

supriyar left a comment

Uh oh!

facebook-github-bot commented Mar 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jerryzh168 commented Mar 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci Bot commented Mar 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CircleCI build failures summary and remediations

🚧 1 upstream failure:

Uh oh!

supriyar Mar 30, 2020

Choose a reason for hiding this comment

Uh oh!

supriyar Mar 30, 2020

Choose a reason for hiding this comment

Uh oh!

jerryzh168 Mar 30, 2020

Choose a reason for hiding this comment

Uh oh!

supriyar left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Mar 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jerryzh168 commented Mar 26, 2020 •

edited

Loading

dr-ci Bot commented Mar 27, 2020 •

edited

Loading