[quant][graphmode][refactor] getGeneralTensorInputs(Node*) -> getPassThroughInputs(Value*)#35558
Closed
jerryzh168 wants to merge 12 commits intogh/jerryzh168/277/basefrom
Closed
[quant][graphmode][refactor] getGeneralTensorInputs(Node*) -> getPassThroughInputs(Value*)#35558jerryzh168 wants to merge 12 commits intogh/jerryzh168/277/basefrom
jerryzh168 wants to merge 12 commits intogh/jerryzh168/277/basefrom
Conversation
…ThroughInputs(Value*) Summary: This is to have a more fined grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 27, 2020
Closed
This was referenced Mar 27, 2020
💊 CircleCI build failures summary and remediationsAs of commit d496f42 (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
❄️ 1 tentatively flaky failure1 failure tentatively classified as flaky but have not triggered reruns to confirm:
|
… -> getPassThroughInputs(Value*)" Summary: This is to have a more fined grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
… -> getPassThroughInputs(Value*)" Summary: This is to have a more fined grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
… -> getPassThroughInputs(Value*)" Summary: This is to have a more fined grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
… -> getPassThroughInputs(Value*)" Summary: This is to have a more fined grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
… -> getPassThroughInputs(Value*)" Summary: This is to have a more fined grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
… -> getPassThroughInputs(Value*)" Summary: This is to have a more fined grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
… -> getPassThroughInputs(Value*)" Summary: This is to have a more fined grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
… -> getPassThroughInputs(Value*)" Summary: This is to have a more fined grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
… -> getPassThroughInputs(Value*)" Summary: This is to have a more fined grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
… -> getPassThroughInputs(Value*)" Summary: This is to have a more fined grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
supriyar
approved these changes
Mar 30, 2020
… -> getPassThroughInputs(Value*)" Summary: This is to have a more fined grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
|
This pull request has been merged in 9018538. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ThroughInputs(Value*) (pytorch#35558) Summary: Pull Request resolved: pytorch#35558 This is to have a more fine grained support for general ops, e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized so we'll have a check for that Test Plan: . Imported from OSS Differential Revision: D20752128 fbshipit-source-id: 825c4c393910a88ecb12e24e9a2f3b05c5d5a7ab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This is to have a more fine grained support for general ops,
e.g. for sort, the first output will have pass through inputs and the second op does not need to be quantized
so we'll have a check for that
Test Plan:
.
Reviewers:
.
Subscribers:
Tasks:
Tags:
Differential Revision: D20752128